Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 37434 Build 34323: arc lint + arc unit
Event Timeline
I think I'd prefer that we didn't do this.
I get the desire to clean up stray whitespace, but this sort of patch ends up being really painful for downstream consumers with local patches, or anyone with ongoing work.
I half disagree. The choice is either make cosmetic changes in a separate revision or with functional changes. If making cosmetic changes when doing functional changes then it's only OK to do cosmetic changes to the lines that were functionally changed but not to lines that were not touched at all. Otherwise it becomes difficult or time consuming for readers of historical patches to discern which of a revision were functional changes and which were cosmetic only. Either keep them separate or don't do them at all.
I'm working on this code and I think all this changes will be lost in the future, or they will take away my desire to merge changes.
I figure that a sweep is better than peicemeal changes to whitespace. A lot of these are extra spaces after braces.
I'll coordinate with ae@ before doing anything as I have changes in dummynet too.