Page MenuHomeFreeBSD

Trim leading/trailing white space in dummynet Tidy up the leading and trailing white space issues highlighted by vim. Avoid touching whitespace that is used for layout and the functions which are entirely space aligned.
AbandonedPublic

Authored by thj on Feb 27 2021, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 6:00 AM
Unknown Object (File)
Mar 25 2024, 7:21 PM
Unknown Object (File)
Nov 14 2023, 12:08 PM
Unknown Object (File)
Nov 12 2023, 2:03 AM
Unknown Object (File)
Oct 13 2023, 11:10 AM
Unknown Object (File)
Oct 11 2023, 1:05 AM
Unknown Object (File)
Oct 7 2023, 12:16 PM
Unknown Object (File)
Jun 10 2023, 9:58 PM
Subscribers

Details

Reviewers
kp
ae
melifaro
Group Reviewers
network

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37434
Build 34323: arc lint + arc unit

Event Timeline

thj requested review of this revision.Feb 27 2021, 3:24 PM

I think I'd prefer that we didn't do this.

I get the desire to clean up stray whitespace, but this sort of patch ends up being really painful for downstream consumers with local patches, or anyone with ongoing work.

I half disagree. The choice is either make cosmetic changes in a separate revision or with functional changes. If making cosmetic changes when doing functional changes then it's only OK to do cosmetic changes to the lines that were functionally changed but not to lines that were not touched at all. Otherwise it becomes difficult or time consuming for readers of historical patches to discern which of a revision were functional changes and which were cosmetic only. Either keep them separate or don't do them at all.

I'm working on this code and I think all this changes will be lost in the future, or they will take away my desire to merge changes.

I figure that a sweep is better than peicemeal changes to whitespace. A lot of these are extra spaces after braces.

I'll coordinate with ae@ before doing anything as I have changes in dummynet too.