Page MenuHomeFreeBSD

cam: Don't permit crashdumps on non-pollable devices.
ClosedPublic

Authored by jhb on Feb 1 2021, 11:32 PM.

Details

Summary

If a disk's SIM doesn't support polling, then it can't be used to
store crashdumps. Leave d_dump NULL in that case so that dumpon(8)
fails gracefully rather than having dumps fail at crash time.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 36663
Build 33552: arc lint + arc unit

Event Timeline

I'm happy with this, but all nvme SIMs support polling... But the change isn't wrong, we'll just never fail to take the if into setting d_dump.

sys/cam/nvme/nvme_da.c
901

All nvme sims support polling...

This revision is now accepted and ready to land.Feb 1 2021, 11:35 PM