Page MenuHomeFreeBSD

cam: Don't permit crashdumps on non-pollable devices.
ClosedPublic

Authored by jhb on Feb 1 2021, 11:32 PM.

Details

Summary

If a disk's SIM doesn't support polling, then it can't be used to
store crashdumps. Leave d_dump NULL in that case so that dumpon(8)
fails gracefully rather than having dumps fail at crash time.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I'm happy with this, but all nvme SIMs support polling... But the change isn't wrong, we'll just never fail to take the if into setting d_dump.

sys/cam/nvme/nvme_da.c
901–902

All nvme sims support polling...

This revision is now accepted and ready to land.Feb 1 2021, 11:35 PM