Page MenuHomeFreeBSD

cam: Don't permit crashdumps on non-pollable devices.
ClosedPublic

Authored by jhb on Feb 1 2021, 11:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 26, 2:36 PM
Unknown Object (File)
Thu, Sep 25, 10:43 PM
Unknown Object (File)
Wed, Sep 24, 2:16 AM
Unknown Object (File)
Sun, Sep 21, 1:17 AM
Unknown Object (File)
Fri, Sep 19, 3:14 AM
Unknown Object (File)
Wed, Sep 17, 4:50 AM
Unknown Object (File)
Sat, Sep 13, 3:45 PM
Unknown Object (File)
Sat, Sep 13, 11:35 AM
Subscribers

Details

Summary

If a disk's SIM doesn't support polling, then it can't be used to
store crashdumps. Leave d_dump NULL in that case so that dumpon(8)
fails gracefully rather than having dumps fail at crash time.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'm happy with this, but all nvme SIMs support polling... But the change isn't wrong, we'll just never fail to take the if into setting d_dump.

sys/cam/nvme/nvme_da.c
901–902

All nvme sims support polling...

This revision is now accepted and ready to land.Feb 1 2021, 11:35 PM