Page MenuHomeFreeBSD
Differential D28454

cam: Don't permit crashdumps on non-pollable devices.
ClosedPublic
Actions

Authored by jhb on Mon, Feb 1, 11:32 PM.

Details

Reviewers
mav
imp
scottl
Group Reviewers
cam
Commits
R10:e07ac3f2fd73: cam: Don't permit crashdumps on non-pollable devices.
Summary

If a disk's SIM doesn't support polling, then it can't be used to
store crashdumps. Leave d_dump NULL in that case so that dumpon(8)
fails gracefully rather than having dumps fail at crash time.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb created this revision.Mon, Feb 1, 11:32 PM
Herald added a reviewer: cam. · View Herald TranscriptMon, Feb 1, 11:32 PM
Herald added a subscriber: dab. · View Herald Transcript
Harbormaster completed remote builds in B36663: Diff 83250.Mon, Feb 1, 11:32 PM
jhb requested review of this revision.Mon, Feb 1, 11:32 PM
jhb added a parent revision: D28453: cam: Permit non-pollable sims..
jhb added a child revision: D28455: iscsi: Mark iSCSI CAM sims as non-pollable..
imp accepted this revision.Mon, Feb 1, 11:35 PM

I'm happy with this, but all nvme SIMs support polling... But the change isn't wrong, we'll just never fail to take the if into setting d_dump.

sys/cam/nvme/nvme_da.c
901–902

All nvme sims support polling...

This revision is now accepted and ready to land.Mon, Feb 1, 11:35 PM
mav accepted this revision.Mon, Feb 1, 11:42 PM
scottl accepted this revision.Tue, Feb 2, 4:39 AM
Closed by commit R10:e07ac3f2fd73: cam: Don't permit crashdumps on non-pollable devices. (authored by jhb). · Explain WhyThu, Feb 11, 9:53 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: R10:e07ac3f2fd73: cam: Don't permit crashdumps on non-pollable devices..

Revision Contents
Changeset List

PathSize
sys/
cam/
ata/
3 lines
nvme/
3 lines
scsi/
5 lines

Diff 83712

View Options

sys/cam/ata/ata_da.c

Loading...
View Options

sys/cam/nvme/nvme_da.c

Loading...
View Options

sys/cam/scsi/scsi_da.c

Loading...