Differential D28197

service.8: Provide example for adding completions to (t)csh
ClosedPublic
Actions

Authored by debdrup on Jan 16 2021, 8:59 PM.

Tags

None

Referenced Files

	F106126824: D28197.diff
	Wed, Dec 25, 8:26 PM

	Unknown Object (File)
	Nov 25 2024, 7:52 AM

	Unknown Object (File)
	Nov 20 2024, 7:50 PM

	Unknown Object (File)
	Nov 16 2024, 7:35 AM

	Unknown Object (File)
	Nov 16 2024, 7:35 AM

	Unknown Object (File)
	Oct 29 2024, 4:10 PM

	Unknown Object (File)
	Oct 20 2024, 8:45 PM

	Unknown Object (File)
	Oct 20 2024, 4:22 PM

View All 43 Files

Subscribers

juan.molina_club.fr

Details

Reviewers

Group Reviewers

Commits

rGc6a112cf84d2: service.8: Provide example for adding completions to (t)csh

Summary

service(8) has an example for bash completion, however bash is third
party and in /usr/share/examples/csh/dot.cshrc is a working example for
csh.

PR: 179497
Submitted by: ohauer@

Test Plan

igor

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36277
Build 33166: arc lint + arc unit

Event Timeline

debdrup created this revision.Jan 16 2021, 8:59 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 16 2021, 8:59 PM

debdrup requested review of this revision.Jan 16 2021, 8:59 PM

Harbormaster completed remote builds in B36277: Diff 82383.Jan 16 2021, 9:00 PM

0mp requested changes to this revision.Jan 16 2021, 9:06 PM

0mp added a subscriber: 0mp.

0mp added inline comments.

usr.sbin/service/service.8
135	Please use .Bd -literal -offset indent xxx .Ed instead of multiple Dl lines.

This revision now requires changes to proceed.Jan 16 2021, 9:06 PM

This revision was not accepted when it landed; it landed in state Needs Revision.Jan 16 2021, 9:06 PM

Closed by commit rGc6a112cf84d2: service.8: Provide example for adding completions to (t)csh (authored by debdrup). · Explain Why

This revision was automatically updated to reflect the committed changes.

debdrup added a commit: rGc6a112cf84d2: service.8: Provide example for adding completions to (t)csh.

juan.molina_club.fr added a subscriber: juan.molina_club.fr.Jan 16 2021, 10:49 PM

juan.molina_club.fr added inline comments.

usr.sbin/service/service.8
139	Minor typo: s/use/used

debdrup added inline comments.Jan 16 2021, 11:02 PM

usr.sbin/service/service.8
139	You're not wrong - but I try to avoid unnecessary churn to the tree, such as a tiny commit to fix a typo. I'll be keeping an eye on reviews for service.8 in the future, as I know someone is working on an addition to service(8), and ask them to fix it then. :) Thanks for your attention to detail, though. :)

Revision Contents
Changeset List

Path

Size

usr.sbin/

service/

9 lines

Diff 82383

usr.sbin/service/service.8

Loading...