Page MenuHomeFreeBSD
Differential D28192

linux: make fstatat(2) handle AT_EMPTY_PATH
ClosedPublic
Actions

Authored by trasz on Jan 16 2021, 4:29 PM.
Tags
None
Referenced Files
F170854602: D28192.id87538.diff
Mon, Sep 7, 1:46 AM
F170802028: D28192.id87538.diff
Sun, Sep 6, 5:43 PM
Unknown Object (File)
Sun, Sep 6, 4:16 AM
Unknown Object (File)
Sat, Sep 5, 4:12 PM
Unknown Object (File)
Sat, Sep 5, 2:43 PM
Unknown Object (File)
Sat, Sep 5, 1:36 PM
Unknown Object (File)
Sat, Sep 5, 11:21 AM
Unknown Object (File)
Sat, Sep 5, 4:44 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
kib
Group Reviewers
Linux Emulation
Commits
rG8e4ef1c3a3d9: linux: make fstatat(2) handle AT_EMPTY_PATH
rG4b45c2bb83a1: linux: make fstatat(2) handle AT_EMPTY_PATH
Summary

Without it, Qt5 apps from Focal fail to start, being unable to load their plugins. It's also necessary for glibc 2.33, as found in Arch snapshots.

PR: 254112
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Jan 16 2021, 4:29 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 16 2021, 4:29 PM
trasz requested review of this revision.Jan 16 2021, 4:29 PM
Harbormaster completed remote builds in B36270: Diff 82372.Jan 16 2021, 4:29 PM
trasz added a reviewer: Linux Emulation.Jan 16 2021, 4:29 PM
trasz updated this revision to Diff 85279.Mar 6 2021, 7:54 PM

Detect unsupported flag.

Harbormaster completed remote builds in B37641: Diff 85279.Mar 6 2021, 7:55 PM
emaste added a subscriber: emaste.Mar 6 2021, 8:10 PM

see also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197778

sys/compat/linux/linux_stats.c
669

Should this be (should we have) LINUX_AT_FDCWD?

trasz added inline comments.Mar 7 2021, 11:29 AM
sys/compat/linux/linux_stats.c
669

Linux uses the same value as we do, -100.

trasz updated this revision to Diff 85293.Mar 7 2021, 12:24 PM

Fix invalid flag detection.

Harbormaster completed remote builds in B37651: Diff 85293.Mar 7 2021, 12:24 PM
trasz added a comment.Mar 8 2021, 3:26 PM

(Tinderboxed.)

trasz updated this revision to Diff 87479.Apr 15 2021, 11:55 AM

Reimplement.

Harbormaster completed remote builds in B38588: Diff 87479.Apr 15 2021, 11:55 AM
trasz edited the summary of this revision. (Show Details)Apr 15 2021, 12:31 PM
trasz edited the summary of this revision. (Show Details)
trasz edited the summary of this revision. (Show Details)Apr 15 2021, 12:33 PM
trasz added a reviewer: kib.Apr 15 2021, 12:50 PM
kib accepted this revision.Apr 15 2021, 12:56 PM
This revision is now accepted and ready to land.Apr 15 2021, 12:56 PM
trasz added a comment.Apr 15 2021, 11:01 PM

(Tinderboxed.)

Closed by commit rG4b45c2bb83a1: linux: make fstatat(2) handle AT_EMPTY_PATH (authored by trasz). · Explain WhyApr 16 2021, 7:57 AM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rG4b45c2bb83a1: linux: make fstatat(2) handle AT_EMPTY_PATH.
trasz added a commit: rG8e4ef1c3a3d9: linux: make fstatat(2) handle AT_EMPTY_PATH.Feb 17 2022, 10:56 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
13 lines

Diff 87538

View Options

sys/compat/linux/linux_stats.c

Loading...