MK_WERROR: Downgrade an error to an information message

[arichardson]

Summary

In 7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f, I replaced all uses of NO_WERROR
with MK_WERROR in the src repo, but this file is also used by ports where
this .error is causing problems.

I'm not sure how many ports use NO_WERROR, so this might be needed if applying
something like https://reviews.freebsd.org/rP561055 to all problematic ports
is not feasible

Reported By: tijl

[emaste]

share/mk/bsd.opts.mk

119

Is it really "should" be used instead? In other words will we revert this change back to a .error for NO_WERROR in the future?

[arichardson]

share/mk/bsd.opts.mk

119

Yes that is definitely better, I copied this from the NO_CLEAN message.

[tijl]

Here are the cases of NO_WERROR in the ports tree. It seems small enough that this patch isn't needed.

astro/gpxloggerd/Makefile:MAKE_ARGS= NO_WERROR=yes
comms/hcidump/files/patch-parser-Makefile:+NO_WERROR= yes
comms/tits/files/patch-Makefile:+NO_WERROR=1
comms/obexapp/Makefile:MAKE_ENV+= NO_WERROR=yes
databases/oracle8-client/files/patch-freebsd-Makefile:+NO_WERROR= yes
databases/clickhouse/Makefile:CMAKE_ARGS= -DNO_WERROR=1 \
devel/linux_libusb/Makefile:MAKE_ARGS+= NO_WERROR=yes
devel/replay/Makefile:MAKE_ENV= WITHOUT_MAN=yes NO_WERROR="defined"
games/bsdgames/Makefile:MAKE_ENV= NO_WERROR=1
graphics/xfpovray/files/BSDmakefile:NO_WERROR= yes
mail/dma/Makefile:MAKE_ENV= __MAKE_CONF=/dev/null SRCCONF=/dev/null NO_WERROR=defined \
net/widentd/Makefile:MAKE_ENV+= NO_WERROR="defined"
net/ipxe/Makefile: NO_WERROR=1 \
net/bsdrcmds/Makefile:MAKE_ENV+= NO_WERROR=1
shells/v7sh/files/Makefile:NO_WERROR=1
textproc/bsdsort/Makefile: NO_WERROR="defined" \
www/bozohttpd/files/patch-Makefile:+NO_WERROR=1
www/websh/Makefile:.if !defined(NO_WERROR) && ${CC} == "cc" || ${CC:T:Mgcc*} != ""

[arichardson]

In D28084#628312, @tijl wrote:

Here are the cases of NO_WERROR in the ports tree. It seems small enough that this patch isn't needed.

astro/gpxloggerd/Makefile:MAKE_ARGS= NO_WERROR=yes
comms/hcidump/files/patch-parser-Makefile:+NO_WERROR= yes
comms/tits/files/patch-Makefile:+NO_WERROR=1
comms/obexapp/Makefile:MAKE_ENV+= NO_WERROR=yes
databases/oracle8-client/files/patch-freebsd-Makefile:+NO_WERROR= yes
databases/clickhouse/Makefile:CMAKE_ARGS= -DNO_WERROR=1 \
devel/linux_libusb/Makefile:MAKE_ARGS+= NO_WERROR=yes
devel/replay/Makefile:MAKE_ENV= WITHOUT_MAN=yes NO_WERROR="defined"
games/bsdgames/Makefile:MAKE_ENV= NO_WERROR=1
graphics/xfpovray/files/BSDmakefile:NO_WERROR= yes
mail/dma/Makefile:MAKE_ENV= __MAKE_CONF=/dev/null SRCCONF=/dev/null NO_WERROR=defined \
net/widentd/Makefile:MAKE_ENV+= NO_WERROR="defined"
net/ipxe/Makefile: NO_WERROR=1 \
net/bsdrcmds/Makefile:MAKE_ENV+= NO_WERROR=1
shells/v7sh/files/Makefile:NO_WERROR=1
textproc/bsdsort/Makefile: NO_WERROR="defined" \
www/bozohttpd/files/patch-Makefile:+NO_WERROR=1
www/websh/Makefile:.if !defined(NO_WERROR) && ${CC} == "cc" || ${CC:T:Mgcc*} != ""

Thanks for checking, I obviously prefer not adding backwards compat logic in the makefiles. Sorry for the inconvenience again!