Page MenuHomeFreeBSD
Differential D28084

MK_WERROR: Downgrade an error to an information message
AbandonedPublic
Actions

Authored by arichardson on Jan 10 2021, 4:27 PM.
Tags
None
Referenced Files
F81676979: D28084.diff
Fri, Apr 19, 7:13 PM
Unknown Object (File)
Dec 22 2023, 9:34 PM
Unknown Object (File)
Dec 14 2023, 8:10 PM
Unknown Object (File)
Aug 17 2023, 1:45 PM
Unknown Object (File)
Aug 16 2023, 10:02 AM
Unknown Object (File)
Jul 24 2023, 1:00 AM
Unknown Object (File)
Jul 11 2023, 1:23 PM
Subscribers
bdrewery
emaste

Details

Reviewers
tijl
brooks
imp
Summary

In 7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f, I replaced all uses of NO_WERROR
with MK_WERROR in the src repo, but this file is also used by ports where
this .error is causing problems.

I'm not sure how many ports use NO_WERROR, so this might be needed if applying
something like https://reviews.freebsd.org/rP561055 to all problematic ports
is not feasible

Reported By: tijl

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36088
Build 32977: arc lint + arc unit

Event Timeline

arichardson created this revision.Jan 10 2021, 4:27 PM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptJan 10 2021, 4:27 PM
arichardson requested review of this revision.Jan 10 2021, 4:27 PM
Harbormaster completed remote builds in B36088: Diff 82034.Jan 10 2021, 4:28 PM
arichardson added reviewers: brooks, imp.Jan 10 2021, 4:28 PM
emaste added inline comments.Jan 10 2021, 5:28 PM
share/mk/bsd.opts.mk
119

Is it really "should" be used instead? In other words will we revert this change back to a .error for NO_WERROR in the future?

arichardson added inline comments.Jan 10 2021, 5:50 PM
share/mk/bsd.opts.mk
119

Yes that is definitely better, I copied this from the NO_CLEAN message.

tijl added a comment.Jan 12 2021, 11:41 AM

Here are the cases of NO_WERROR in the ports tree. It seems small enough that this patch isn't needed.

astro/gpxloggerd/Makefile:MAKE_ARGS= NO_WERROR=yes
comms/hcidump/files/patch-parser-Makefile:+NO_WERROR= yes
comms/tits/files/patch-Makefile:+NO_WERROR=1
comms/obexapp/Makefile:MAKE_ENV+= NO_WERROR=yes
databases/oracle8-client/files/patch-freebsd-Makefile:+NO_WERROR= yes
databases/clickhouse/Makefile:CMAKE_ARGS= -DNO_WERROR=1 \
devel/linux_libusb/Makefile:MAKE_ARGS+= NO_WERROR=yes
devel/replay/Makefile:MAKE_ENV= WITHOUT_MAN=yes NO_WERROR="defined"
games/bsdgames/Makefile:MAKE_ENV= NO_WERROR=1
graphics/xfpovray/files/BSDmakefile:NO_WERROR= yes
mail/dma/Makefile:MAKE_ENV= __MAKE_CONF=/dev/null SRCCONF=/dev/null NO_WERROR=defined \
net/widentd/Makefile:MAKE_ENV+= NO_WERROR="defined"
net/ipxe/Makefile: NO_WERROR=1 \
net/bsdrcmds/Makefile:MAKE_ENV+= NO_WERROR=1
shells/v7sh/files/Makefile:NO_WERROR=1
textproc/bsdsort/Makefile: NO_WERROR="defined" \
www/bozohttpd/files/patch-Makefile:+NO_WERROR=1
www/websh/Makefile:.if !defined(NO_WERROR) && ${CC} == "cc" || ${CC:T:Mgcc*} != ""

arichardson abandoned this revision.Jan 20 2021, 9:58 AM
In D28084#628312, @tijl wrote:

Here are the cases of NO_WERROR in the ports tree. It seems small enough that this patch isn't needed.

astro/gpxloggerd/Makefile:MAKE_ARGS= NO_WERROR=yes
comms/hcidump/files/patch-parser-Makefile:+NO_WERROR= yes
comms/tits/files/patch-Makefile:+NO_WERROR=1
comms/obexapp/Makefile:MAKE_ENV+= NO_WERROR=yes
databases/oracle8-client/files/patch-freebsd-Makefile:+NO_WERROR= yes
databases/clickhouse/Makefile:CMAKE_ARGS= -DNO_WERROR=1 \
devel/linux_libusb/Makefile:MAKE_ARGS+= NO_WERROR=yes
devel/replay/Makefile:MAKE_ENV= WITHOUT_MAN=yes NO_WERROR="defined"
games/bsdgames/Makefile:MAKE_ENV= NO_WERROR=1
graphics/xfpovray/files/BSDmakefile:NO_WERROR= yes
mail/dma/Makefile:MAKE_ENV= __MAKE_CONF=/dev/null SRCCONF=/dev/null NO_WERROR=defined \
net/widentd/Makefile:MAKE_ENV+= NO_WERROR="defined"
net/ipxe/Makefile: NO_WERROR=1 \
net/bsdrcmds/Makefile:MAKE_ENV+= NO_WERROR=1
shells/v7sh/files/Makefile:NO_WERROR=1
textproc/bsdsort/Makefile: NO_WERROR="defined" \
www/bozohttpd/files/patch-Makefile:+NO_WERROR=1
www/websh/Makefile:.if !defined(NO_WERROR) && ${CC} == "cc" || ${CC:T:Mgcc*} != ""

Thanks for checking, I obviously prefer not adding backwards compat logic in the makefiles. Sorry for the inconvenience again!

Revision Contents
Changeset List

PathSize
share/
mk/
8 lines

Diff 82034

View Options

share/mk/bsd.opts.mk

Loading...