Page MenuHomeFreeBSD
Differential D27678

Update the build infrastructure to use Git instead of Subversion
ClosedPublic
Actions

Authored by rene on Dec 19 2020, 12:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 8:20 AM
Unknown Object (File)
Sat, Apr 20, 9:44 PM
Unknown Object (File)
Sat, Apr 20, 9:44 PM
Unknown Object (File)
Sat, Apr 20, 9:44 PM
Unknown Object (File)
Sat, Apr 20, 9:44 PM
Unknown Object (File)
Sat, Apr 20, 9:44 PM
Unknown Object (File)
Sat, Apr 20, 9:44 PM
Unknown Object (File)
Fri, Apr 19, 9:53 AM
View All 56 Files
Subscribers
bcr
bdrewery
emaste
ygy

Details

Reviewers
carlavilla
gjb
ygy
bcr
Group Reviewers
doceng
Commits
R9:eaf07aef5605: Update the build infrastructure to use Git instead of Subversion
Summary

The doc repository is not mirrored to Subversion so updating the
repository from Subversion does not make sense. Remove
Subversion-specific files too.

While here remove now defunct $FreeBSD$ markers in affected files.

Test Plan

make clean
make update
make

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 35532
Build 32433: arc lint + arc unit

Event Timeline

rene created this revision.Dec 19 2020, 12:54 PM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptDec 19 2020, 12:54 PM
rene requested review of this revision.Dec 19 2020, 12:54 PM
Harbormaster completed remote builds in B35532: Diff 80940.Dec 19 2020, 12:54 PM
rene added reviewers: carlavilla, gjb, doceng.Dec 19 2020, 12:56 PM
ygy added a subscriber: ygy.Dec 19 2020, 1:05 PM
rene updated this revision to Diff 80942.Dec 19 2020, 1:49 PM
  • Convert share/tools/webupdate a bit more too and remove defunct $FreeBSD$
Harbormaster completed remote builds in B35534: Diff 80942.Dec 19 2020, 1:49 PM
ygy added inline comments.Dec 19 2020, 2:27 PM
share/mk/doc.docbook.mk
101

Minor nit: Git revision number is ...

106

Just wondering, is there no equivalent git command to achieve this? And if there exists, how will they compare with scanning through embedded version strings.

share/tools/webupdate
41 ↗(On Diff #80942)

?

ygy added a reviewer: ygy.Dec 19 2020, 2:28 PM
ygy added inline comments.
share/tools/webupdate
41 ↗(On Diff #80942)

Ah I read it wrong. Please disregard ;)

rene updated this revision to Diff 80950.Dec 19 2020, 2:45 PM
  • Fix a grammar nit.
Harbormaster completed remote builds in B35538: Diff 80950.Dec 19 2020, 2:45 PM
rene marked an inline comment as done.Dec 19 2020, 2:46 PM
rene marked 2 inline comments as done.
bcr accepted this revision as: bcr.Dec 19 2020, 6:56 PM
bcr added a subscriber: bcr.

Looks good to me. Thanks for the update.

This revision is now accepted and ready to land.Dec 19 2020, 6:56 PM
ygy accepted this revision.Dec 19 2020, 6:57 PM
emaste added a comment.Dec 19 2020, 7:15 PM

LGTM

Makefile
36

We can always restore similar logic if we add got or gitup to the base system

share/tools/webupdate
27 ↗(On Diff #80950)

This SVN ref is stale now?

rene added inline comments.Dec 19 2020, 8:31 PM
Makefile
36

Yes ;)

share/tools/webupdate
27 ↗(On Diff #80950)

Looking at the logic it references the main branch of doc and also some src and local(?)l directories, so it is a bit in flux. I guess "from SVN or Git" will do for now.

rene updated this revision to Diff 80962.Dec 19 2020, 8:34 PM
  • webupdate: replace a reference of "SVN" by "VCS".
This revision now requires review to proceed.Dec 19 2020, 8:34 PM
Harbormaster completed remote builds in B35545: Diff 80962.Dec 19 2020, 8:34 PM
rene added inline comments.Dec 19 2020, 8:34 PM
share/tools/webupdate
27 ↗(On Diff #80950)

or just "VCS" as I did in the end.

rene marked 2 inline comments as done.Dec 22 2020, 10:47 PM
rene updated this revision to Diff 81080.Dec 22 2020, 11:36 PM
  • Convert share/tools/webupdate a bit more too and remove defunct $FreeBSD$
  • Fix a grammar nit.
  • webupdate: replace a reference of "SVN" by "VCS".
Harbormaster completed remote builds in B35635: Diff 81080.Dec 22 2020, 11:37 PM
gjb accepted this revision.Dec 23 2020, 2:45 PM
gjb added inline comments.
share/tools/webupdate
27 ↗(On Diff #80950)

Once stable/11 is EoL, we can kill the subtrees (and its related logic).

This revision is now accepted and ready to land.Dec 23 2020, 2:45 PM
ygy accepted this revision.Dec 23 2020, 3:07 PM
Closed by commit R9:eaf07aef5605: Update the build infrastructure to use Git instead of Subversion (authored by rene). · Explain WhyDec 23 2020, 8:52 PM
This revision was automatically updated to reflect the committed changes.
rene added a commit: R9:eaf07aef5605: Update the build infrastructure to use Git instead of Subversion.

Revision Contents
Changeset List

PathSize
18 lines
share/
misc/
mk/
25 lines

Diff 80940

View Options

Makefile

Loading...
View Options

share/misc/svn_props.txt

Loading...
View Options

share/mk/doc.docbook.mk

Loading...