Page MenuHomeFreeBSD

Skip the vm.pmap.kernel_maps sysctl by default.
ClosedPublic

Authored by jhb on Dec 7 2020, 11:09 PM.

Details

Summary

This sysctl node generates very verbose output, so don't trigger it
for sysctl -a or sysctl vm.pmap.

Test Plan
  • I tried to use 'sysctl vm.pmap' on my laptop to see the status of PTI and was flooded with many, many lines of output

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Dec 7 2020, 11:09 PM
This revision is now accepted and ready to land.Dec 7 2020, 11:11 PM

Hmm, @freqlabs, I was testing this, and I found that while 'sysctl vm' skipped this sysctl, 'sysctl vm.pmap' did not, so it seems like something is broken with the CTLFLAG_SKIP handling.

To be clear, vm.pmap.kernel_maps is the node in question, so I would expect sysctl vm.pmap to skip it.

@jhb Thanks for the heads up. It's working as intended in other cases but clearly not in this case. I'm looking into it.

This revision was automatically updated to reflect the committed changes.