bhyve: virtio DISCARD doesn't work for 'sectorsize=512/4096'
ClosedPublic
Actions

Authored by gusev.vitaliy_gmail.com on Nov 3 2020, 1:58 PM.

Details

Reviewers

allanjude
jhb

Commits

rS367393: VirtIO: Make sure the guest knows the TRIM alignment requirements

Summary

If bhyve is used to emulate 512e access in guest OS, then discard addresses should be properly aligned. Otherwise ioctl DIOCGDELETE fails with 4K geom devices (look at g_dev_ioctl() in sys/geom/geom_dev.c).

So take into account the physical sector size as well.

Test Plan

Assign zvol with 4K volblocksize via geom to VM with different sector size argument: 512/4096, 4096/4096, etc.

All cases work fine with patch.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

gusev.vitaliy_gmail.com created this revision.Nov 3 2020, 1:58 PM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 3 2020, 1:58 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

gusev.vitaliy_gmail.com requested review of this revision.Nov 3 2020, 1:58 PM

gusev.vitaliy_gmail.com removed a reviewer: bhyve.Nov 4 2020, 10:06 AM

mateusz_serveraptor.com added a subscriber: mateusz_serveraptor.com.Nov 4 2020, 11:28 AM

allanjude accepted this revision.Nov 5 2020, 5:00 PM

This revision is now accepted and ready to land.Nov 5 2020, 5:00 PM

Closed by commit rS367393: VirtIO: Make sure the guest knows the TRIM alignment requirements (authored by allanjude). · Explain WhyNov 5 2020, 8:10 PM

This revision was automatically updated to reflect the committed changes.

allanjude added a commit: rS367393: VirtIO: Make sure the guest knows the TRIM alignment requirements.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_virtio_block.c

2 lines

Diff 79126

View Options

usr.sbin/bhyve/pci_virtio_block.c

bhyve: virtio DISCARD doesn't work for 'sectorsize=512/4096'ClosedPublicActions