Page MenuHomeFreeBSD

Optimize set_syscall_retval for arm64
ClosedPublic

Authored by trasz on Oct 28 2020, 7:44 PM.
Tags
None
Referenced Files
F131551828: D26991.diff
Thu, Oct 9, 4:47 AM
Unknown Object (File)
Sun, Oct 5, 2:47 PM
Unknown Object (File)
Sun, Oct 5, 7:38 AM
Unknown Object (File)
Mon, Sep 22, 9:33 PM
Unknown Object (File)
Mon, Sep 15, 1:20 PM
Unknown Object (File)
Mon, Sep 15, 1:19 PM
Unknown Object (File)
Mon, Sep 15, 1:09 PM
Unknown Object (File)
Sun, Sep 14, 4:10 PM

Details

Summary

Optimize set_syscall_retval() for arm64 by predicting the return
value to be zero.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34449
Build 31551: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Oct 28 2020, 7:44 PM

similar to amd64,

if (__predict_true(error == 0)) {
        frame->tf_rax = td->td_retval[0];
        frame->tf_rdx = td->td_retval[1];
        frame->tf_rflags &= ~PSL_C;
        return;
}
emaste added a subscriber: mhorne.

Maybe worth a comment about the microoptimization?

This revision is now accepted and ready to land.Jan 8 2021, 3:37 PM

See also, the analogous commit for riscv: rS367138.

This revision was automatically updated to reflect the committed changes.