TCP Cubic: improve reaction to (and rollback from) RTO
ClosedPublic
Actions

Authored by cc on Oct 15 2020, 8:54 PM.

Details

Reviewers

rscheff
tuexen
rgrimes
rrs

Group Reviewers

NetApp
transport

Commits

rS367753: MFC r367008: TCP Cubic: improve reaction to (and rollback from) RTO
rS367008: TCP Cubic: improve reaction to (and rollback from) RTO

Summary

fix compliancy issue of CUBIC RTO handling according to RFC8312 section 4.7
add CUBIC CC_RTO_ERR handling

This is the second patch of two consecutive patches on CUBIC to improve
reaction to (and rollback from) RTO.

Test Plan

Performed multiple unit tests and inspected the evolution of the cubic-internal
state across packet RTO/RTO_ERR scenarios, by using Emulab.net.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cc created this revision.Oct 15 2020, 8:54 PM

Herald added a reviewer: transport. · View Herald TranscriptOct 15 2020, 8:54 PM

Herald added a subscriber: melifaro. · View Herald Transcript

cc requested review of this revision.Oct 15 2020, 8:54 PM

discussed this internally, but want to have external review before commit.

rrs accepted this revision.Oct 22 2020, 2:29 PM

This revision is now accepted and ready to land.Oct 22 2020, 2:29 PM

tuexen accepted this revision.Oct 22 2020, 2:29 PM

Closed by commit rS367008: TCP Cubic: improve reaction to (and rollback from) RTO (authored by rscheff). · Explain WhyOct 24 2020, 4:12 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rS367008: TCP Cubic: improve reaction to (and rollback from) RTO.

Herald added a subscriber: imp. · View Herald TranscriptOct 24 2020, 4:12 PM

rscheff added a commit: rS367753: MFC r367008: TCP Cubic: improve reaction to (and rollback from) RTO.Nov 17 2020, 8:11 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

cc/

cc_cubic.c

70 lines

Diff 78702

View Options

head/sys/netinet/cc/cc_cubic.c

TCP Cubic: improve reaction to (and rollback from) RTOClosedPublicActions