Page MenuHomeFreeBSD

ports-mgmt/pkg: Strip binaries
AbandonedPublic

Authored by 0mp on Oct 4 2020, 7:51 PM.

Details

Reviewers
bapt
manu
bdrewery
Group Reviewers
pkg
Restricted Owners Package(Owns No Changed Paths)
Summary
ports-mgmt/pkg: Strip binaries

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33987
Build 31180: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 4 2020, 7:51 PM
0mp requested review of this revision.Oct 4 2020, 7:51 PM

Fix a typo that got in just before submitting the patch

0mp planned changes to this revision.Oct 28 2020, 3:21 PM

It's probably better to keep those binaries not stripped for debugging. Instead, it might be better to document that they are not stripped on purpose.

In D26667#601994, @0mp wrote:

It's probably better to keep those binaries not stripped for debugging. Instead, it might be better to document that they are not stripped on purpose.

I was in favor of this review so I'm surprised by that.

Am I missing a reason that we'd want all users to be ready to use debugging symbols in pkg? It seems to me that the very, very small proportion of users who are ever likely to use debugging symbols in pkg are trivially capable of building with WITH_DEBUG=yes (i.e. they are unlikely to be relying on the pre-built packages from pkg.FreeBSD.org and are probably building pkg locally already).

In D26667#601994, @0mp wrote:

It's probably better to keep those binaries not stripped for debugging. Instead, it might be better to document that they are not stripped on purpose.

I was in favor of this review so I'm surprised by that.

Am I missing a reason that we'd want all users to be ready to use debugging symbols in pkg? It seems to me that the very, very small proportion of users who are ever likely to use debugging symbols in pkg are trivially capable of building with WITH_DEBUG=yes (i.e. they are unlikely to be relying on the pre-built packages from pkg.FreeBSD.org and are probably building pkg locally already).

I can still commit this patch if there is an interest.