Page MenuHomeFreeBSD
Differential D26667

ports-mgmt/pkg: Strip binaries
AbandonedPublic
Actions

Authored by 0mp on Oct 4 2020, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 1:26 PM
Unknown Object (File)
Fri, Mar 29, 9:27 AM
Unknown Object (File)
Jan 15 2024, 1:46 AM
Unknown Object (File)
Dec 20 2023, 3:30 AM
Unknown Object (File)
Nov 24 2023, 4:54 PM
Unknown Object (File)
Nov 18 2023, 8:23 PM
Unknown Object (File)
Nov 18 2023, 7:44 PM
Unknown Object (File)
Sep 24 2023, 3:29 PM
View All 11 Files
Subscribers
adamw
mat

Details

Reviewers
bapt
manu
bdrewery
Group Reviewers
pkg
Restricted Owners Package(Owns No Changed Paths)
Summary
ports-mgmt/pkg: Strip binaries

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 33986
Build 31179: arc lint + arc unit

Event Timeline

0mp created this revision.Oct 4 2020, 7:51 PM
Owners added a reviewer: Restricted Owners Package.Oct 4 2020, 7:51 PM
Herald added a reviewer: bdrewery. · View Herald TranscriptOct 4 2020, 7:51 PM
Herald added a subscriber: mat. · View Herald Transcript
0mp requested review of this revision.Oct 4 2020, 7:51 PM
Harbormaster completed remote builds in B33986: Diff 77866.Oct 4 2020, 7:52 PM
0mp updated this revision to Diff 77867.Oct 4 2020, 9:10 PM

Fix a typo that got in just before submitting the patch

Harbormaster completed remote builds in B33987: Diff 77867.Oct 4 2020, 9:10 PM
0mp planned changes to this revision.Oct 28 2020, 3:21 PM

It's probably better to keep those binaries not stripped for debugging. Instead, it might be better to document that they are not stripped on purpose.

adamw added a subscriber: adamw.Oct 28 2020, 3:34 PM
In D26667#601994, @0mp wrote:

It's probably better to keep those binaries not stripped for debugging. Instead, it might be better to document that they are not stripped on purpose.

I was in favor of this review so I'm surprised by that.

Am I missing a reason that we'd want all users to be ready to use debugging symbols in pkg? It seems to me that the very, very small proportion of users who are ever likely to use debugging symbols in pkg are trivially capable of building with WITH_DEBUG=yes (i.e. they are unlikely to be relying on the pre-built packages from pkg.FreeBSD.org and are probably building pkg locally already).

0mp abandoned this revision.Nov 4 2020, 10:41 AM
In D26667#602003, @adamw wrote:
In D26667#601994, @0mp wrote:

It's probably better to keep those binaries not stripped for debugging. Instead, it might be better to document that they are not stripped on purpose.

I was in favor of this review so I'm surprised by that.

Am I missing a reason that we'd want all users to be ready to use debugging symbols in pkg? It seems to me that the very, very small proportion of users who are ever likely to use debugging symbols in pkg are trivially capable of building with WITH_DEBUG=yes (i.e. they are unlikely to be relying on the pre-built packages from pkg.FreeBSD.org and are probably building pkg locally already).

I can still commit this patch if there is an interest.

Revision Contents
Changeset List

PathSize
ports-mgmt/
pkg/
4 lines

Diff 77866

View Options

ports-mgmt/pkg/Makefile

Loading...