Fix fixjobc+orhpanage.
ClosedPublic
Actions

Authored by kib on Sep 12 2020, 6:54 PM.

Details

Reviewers

Commits

rS365815: Add check_pgrp_jobc() calls into process exit path.
rS365814: Fix fixjobc+orhpanage.
rS365813: Assert that P_TREE_GRPEXITED is set only once.
rS365812: proc_realparent: if p_oppid does not match pid of the current parent
rS365811: Improve ddb 'show pgrpdump' command.

Summary

Reported by: trasz
PR: 249257

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 33582

Event Timeline

kib created this revision.Sep 12 2020, 6:54 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 12 2020, 6:54 PM

kib requested review of this revision.Sep 12 2020, 6:54 PM

Harbormaster completed remote builds in B33528: Diff 76955.Sep 12 2020, 6:54 PM

One more replacement of bare p->p_pptr by proc_realparent(p).

Harbormaster completed remote builds in B33534: Diff 76961.Sep 12 2020, 10:43 PM

emaste added a subscriber: emaste.Sep 14 2020, 3:58 PM

Update to the current diff, as being tested:
Most important change, correct calculation of the parent for exiting process. For jobc purposes, we must use realparent, but if it is also exiting, we should fall to reaper, then recursively find non-exiting reaper.
Improve ddb command to show more useful information of process groups + job control state.

Harbormaster completed remote builds in B33582: Diff 77083.Sep 15 2020, 10:38 PM

I have completed a full stress2 test.
I have not observed any problems with this patch.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 9:34 PM

Closed by commit rS365811: Improve ddb 'show pgrpdump' command. (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS365811: Improve ddb 'show pgrpdump' command..

kib added a commit: rS365812: proc_realparent: if p_oppid does not match pid of the current parent.Sep 16 2020, 9:38 PM

kib added a commit: rS365813: Assert that P_TREE_GRPEXITED is set only once..Sep 16 2020, 9:41 PM

kib added a commit: rS365814: Fix fixjobc+orhpanage..Sep 16 2020, 9:47 PM

kib added a commit: rS365815: Add check_pgrp_jobc() calls into process exit path..Sep 16 2020, 9:49 PM