Differential D26125

Use pmap_mapbios() to map ACPI tables on amd64 and i386.
ClosedPublic
Actions

Authored by markj on Aug 19 2020, 8:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 22, 1:06 AM

	Unknown Object (File)
	Mon, Jan 6, 3:37 AM

	Unknown Object (File)
	Dec 18 2024, 7:02 AM

	Unknown Object (File)
	Oct 14 2024, 2:03 AM

	Unknown Object (File)
	Oct 7 2024, 2:35 AM

	Unknown Object (File)
	Oct 7 2024, 2:35 AM

	Unknown Object (File)
	Oct 7 2024, 2:35 AM

	Unknown Object (File)
	Oct 7 2024, 2:03 AM

View All 70 Files

Subscribers

Details

Reviewers

jhb
kib
mav
manu

Commits

rS364411: Use pmap_mapbios() to map ACPI tables on amd64 and i386.

Summary

pmap_kenter_temporary() uses the fixed-size crashdump map. Moreover,
the ACPI table-mapping code was not verifying that the table fits in
this map, so with large tables we could clobber adjacent mappings. The
use of the crashdump map here seems to predate support for "preinit"
mappings on amd64 and i386; I can't see any reason not to use
pmap_mapbios() now, like arm64 does.

Also remove an unused "offset" parameter from map_table() on arm64.

PR: 248746

Test Plan

Booted several amd64 systems and an i386 VM. gallatin@ reported that
this fixes PR 248746 for him.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 19 2020, 8:32 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 19 2020, 8:32 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

markj requested review of this revision.Aug 19 2020, 8:32 PM

Harbormaster completed remote builds in B33073: Diff 76007.Aug 19 2020, 8:32 PM

markj edited the summary of this revision. (Show Details)Aug 19 2020, 8:33 PM

markj edited the test plan for this revision. (Show Details)

markj edited reviewers, added: jhb, kib, mav; removed: manu.

Herald added a reviewer: manu. · View Herald TranscriptAug 19 2020, 8:33 PM

kib accepted this revision.Aug 19 2020, 9:47 PM

This revision is now accepted and ready to land.Aug 19 2020, 9:47 PM

I am not familiar with pmap_mapbios() history, but if it should work now -- great.

Closed by commit rS364411: Use pmap_mapbios() to map ACPI tables on amd64 and i386. (authored by markj). · Explain WhyAug 20 2020, 12:53 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS364411: Use pmap_mapbios() to map ACPI tables on amd64 and i386..

Herald added a subscriber: imp. · View Herald TranscriptAug 20 2020, 12:53 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

acpica/

111 lines

i386/

acpica/

109 lines

Diff 76012

head/sys/amd64/acpica/acpi_machdep.c

Loading...

head/sys/i386/acpica/acpi_machdep.c

Loading...