arm64: update instruction set attribute register definitions
ClosedPublic
Actions

Authored by mhorne on Aug 11 2020, 7:20 PM.

Details

Reviewers

manu
andrew
markj

Commits

rS364254: arm64: update instruction set attribute register definitions

Summary

This adds definitions for the latest additions to the AA64ISAR[01] ID
registers. This brings the definitions for these registers in sync with
ARMv8.6 initial spec release.

An upcoming change will parse many of these fields for HWCAP features.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Aug 11 2020, 7:20 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 11 2020, 7:20 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

mhorne requested review of this revision.Aug 11 2020, 7:21 PM

Harbormaster completed remote builds in B32921: Diff 75695.Aug 11 2020, 7:21 PM

mhorne added reviewers: andrew, markj.Aug 11 2020, 7:21 PM

mhorne added a child revision: D26031: arm64: export new HWCAP features.Aug 11 2020, 7:37 PM

markj accepted this revision.Aug 11 2020, 9:13 PM

markj added inline comments.

sys/arm64/arm64/identcpu.c
375 ↗	(On Diff #75695)	"TLBIOS" and "TLBIOSR" perhaps?

This revision is now accepted and ready to land.Aug 11 2020, 9:13 PM

manu accepted this revision.Aug 12 2020, 7:24 AM

andrew added inline comments.Aug 12 2020, 9:56 AM

sys/arm64/arm64/identcpu.c
375 ↗	(On Diff #75695)	We should give the macros better names, and report them differently so we can tell which we have from dmesg.
382–383 ↗	(On Diff #75695)	Can you give the macros better names, e.g. `_TS_CondM_8_4` and `_TS_CondM_8_5`

Improve the names of several macros.

This revision now requires review to proceed.Aug 12 2020, 3:10 PM

Harbormaster completed remote builds in B32941: Diff 75730.Aug 12 2020, 3:10 PM

mhorne marked 3 inline comments as done.Aug 12 2020, 3:11 PM

mhorne added inline comments.

sys/arm64/arm64/identcpu.c
540 ↗	(On Diff #75730)	What is the distinction between MRS_EXACT and MRS_LOWER? I looked but had a hard time understanding the purpose.

andrew added inline comments.Aug 12 2020, 4:06 PM

sys/arm64/arm64/identcpu.c
540 ↗	(On Diff #75730)	`MRS_EXACT` is shorthand for `MRS_EXACT_VAL(0)`, i.e. always set the field to 0. `MRS_LOWER` will perform a comparison between the current and new field values and use the lower (signed or unsigned) of the two.