Add SOL_LOCAL symbolic constant for unix socket option level.
ClosedPublic
Actions

Authored by kib on Aug 3 2020, 5:07 PM.

Details

Reviewers

emaste
kevans
markj
allanjude

Commits

rS363813: Add SOL_LOCAL symbolic constant for unix socket option level.

Summary

The constant seems to exists on MacOS X >= 10.8.

Requested by: swills

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 3 2020, 5:07 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2020, 5:07 PM

kib requested review of this revision.Aug 3 2020, 5:07 PM

Harbormaster completed remote builds in B32725: Diff 75315.Aug 3 2020, 5:07 PM

I did not added uses to contrib sources, i.e. tests, bsnmpd, and heimdal.

Thanks! I noticed SOL_SOCKET is in socket.h, so I'm not sure if SOL_SOCKET and SOL_LOCAL should be in the same file or not. Looks fine either way to me.

Reviewed By: allanjude

This revision is now accepted and ready to land.Aug 3 2020, 8:52 PM

In D25933#574608, @swills wrote:

Thanks! I noticed SOL_SOCKET is in socket.h, so I'm not sure if SOL_SOCKET and SOL_LOCAL should be in the same file or not. Looks fine either way to me.

MacOS provides it in sys/un.h.

kevans accepted this revision.Aug 3 2020, 10:03 PM

Closed by commit rS363813: Add SOL_LOCAL symbolic constant for unix socket option level. (authored by kib). · Explain WhyAug 3 2020, 10:13 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS363813: Add SOL_LOCAL symbolic constant for unix socket option level..