Add crypto_initreq() and crypto_destroyreq().
ClosedPublic
Actions

Authored by jhb on Jul 16 2020, 6:24 PM.

Details

Reviewers

markj
gallatin
jmg

Group Reviewers

manpages

Commits

rS363262: Add crypto_initreq() and crypto_destroyreq().

Summary

These routines are similar to crypto_getreq() and crypto_freereq()
but operate on caller-supplied storage instead of allocating crypto
requests from a UMA zone.

Test Plan

used this with some KTLS performance testing

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jul 16 2020, 6:24 PM

jhb created this revision.

Harbormaster completed remote builds in B32365: Diff 74534.Jul 16 2020, 6:24 PM

LGTM aside from the comments.

sys/opencrypto/crypto.c
1768 ↗	(On Diff #74534)	Style doesn't require the extra newline anymore.
1796 ↗	(On Diff #74534)	This needs to be conditional on crp != NULL.

This revision is now accepted and ready to land.Jul 16 2020, 6:30 PM

Added @asomers since Alan's been looking at GELI stuff. One of the things I changed in the OCF rework was to make GELI use crypto_getreq instead of preallocating space for the crypto requests along with other data it was already allocating. That part could be reverted now to using this API instead and doing fewer allocations. (It's still better than the old OCF bits that needed the crd's as well as the crp).

jhb marked 2 inline comments as done.Jul 16 2020, 8:16 PM

jhb added inline comments.