Page MenuHomeFreeBSD

Fix Coverity issues in OFED
ClosedPublic

Authored by vangyzen on Jul 15 2020, 1:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 8:36 PM
Unknown Object (File)
Fri, Dec 27, 5:53 PM
Unknown Object (File)
Nov 27 2024, 8:06 AM
Unknown Object (File)
Nov 27 2024, 8:06 AM
Unknown Object (File)
Nov 27 2024, 8:05 AM
Unknown Object (File)
Nov 27 2024, 7:45 AM
Unknown Object (File)
Nov 11 2024, 4:49 PM
Unknown Object (File)
Sep 29 2024, 1:40 PM

Details

Summary
  • read_ibdiag_config NULL deref
  • read_ibdiag_config mem leak
  • ib_mad_inv_field_str Missing comma in a string array initialization
  • print_node_header NULL deref
  • diff_node_ports copy-paste error
  • ibportstate.c main() missing break in switch
  • set_thresholds NULL ptr deref
  • dump_unicast_tables leaks mapnd
  • umad_cm_attr_str dead code
  • __ibv_close_device close(-1)
  • check return value of listen()
  • mlx5 bitmap.h - bad bit shift - UB
  • get_dst_addr check return value of inet_pton
  • osm_perfmgr_init check return value of cl_spinlock_init
  • osm_port_new memory leak on error path
  • sa_mad_ctrl_rcv_callback missing break in switch case

I did not include CID numbers because these were found by an internal run at Isilon.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32339
Build 29820: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 15 2020, 2:21 AM
kib added inline comments.
contrib/ofed/libibverbs/examples/rc_pingpong.c
276

== -1 or, in style with other places around, < 0.

There and below.

This revision was automatically updated to reflect the committed changes.