Page MenuHomeFreeBSD

Fix Coverity issues in OFED
ClosedPublic

Authored by vangyzen on Jul 15 2020, 1:56 AM.

Details

Summary
  • read_ibdiag_config NULL deref
  • read_ibdiag_config mem leak
  • ib_mad_inv_field_str Missing comma in a string array initialization
  • print_node_header NULL deref
  • diff_node_ports copy-paste error
  • ibportstate.c main() missing break in switch
  • set_thresholds NULL ptr deref
  • dump_unicast_tables leaks mapnd
  • umad_cm_attr_str dead code
  • __ibv_close_device close(-1)
  • check return value of listen()
  • mlx5 bitmap.h - bad bit shift - UB
  • get_dst_addr check return value of inet_pton
  • osm_perfmgr_init check return value of cl_spinlock_init
  • osm_port_new memory leak on error path
  • sa_mad_ctrl_rcv_callback missing break in switch case

I did not include CID numbers because these were found by an internal run at Isilon.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Jul 15 2020, 2:21 AM
kib added inline comments.
contrib/ofed/libibverbs/examples/rc_pingpong.c
276 ↗(On Diff #74472)

== -1 or, in style with other places around, < 0.

There and below.

This revision was automatically updated to reflect the committed changes.