Paths

Table of Contentst

Differential D24775

Remove MD5 HMAC from OCF.
ClosedPublic
Actions

Authored by jhb on May 8 2020, 6:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 28 2024, 9:31 PM

	Unknown Object (File)
	Mar 19 2024, 3:54 PM

	Unknown Object (File)
	Mar 19 2024, 2:40 PM

	Unknown Object (File)
	Jan 15 2024, 2:44 PM

	Unknown Object (File)
	Dec 27 2023, 9:32 PM

	Unknown Object (File)
	Dec 27 2023, 9:32 PM

	Unknown Object (File)
	Dec 27 2023, 9:31 PM

	Unknown Object (File)
	Dec 27 2023, 9:18 PM

View All 35 Files

Subscribers

Details

Reviewers

cem
jmg

Group Reviewers

Commits

rS360936: Remove MD5 HMAC from OCF.

Summary

There are no in-kernel consumers.

Test Plan

make tinderbox

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 30993
Build 28700: arc lint + arc unit

Event Timeline

jhb requested review of this revision.May 8 2020, 6:46 PM

jhb created this revision.

Harbormaster completed remote builds in B30993: Diff 71570.May 8 2020, 6:46 PM

jhb added a parent revision: D24774: kgssapi no longer supports RC4, so don't list it as a build dependency..May 8 2020, 6:48 PM

Thanks.

sys/mips/cavium/cryptocteon/cavium_crypto.c
464	This deserves to be removed for this function name alone
sys/mips/cavium/cryptocteon/cryptocteonvar.h
66	Yeah it's almost like they should have names that reflect what they do
sys/opencrypto/cryptodev.h
77	I might keep this constant, even if unused. I don't know if this is the best header for it, but given proximity to the other similar values, it seems ok.
90	Ditto. Even if we don't use the algorithm in OCF it is occasionally handy to have these numbers as reference points.

This revision is now accepted and ready to land.May 9 2020, 2:22 PM

jhb added inline comments.May 11 2020, 9:41 PM

sys/opencrypto/cryptodev.h
90	<sys/md5.h> already has `MD5_DIGEST_LENGTH` and `MD5_BLOCK_LENGTH` and any in-kernel users of MD5 should be using that header and its constants. I'd like to keep this header limited to what OCF uses / supports.

cem added inline comments.May 11 2020, 9:48 PM

sys/opencrypto/cryptodev.h
90	perfect.

Closed by commit rS360936: Remove MD5 HMAC from OCF. (authored by jhb). · Explain WhyMay 11 2020, 10:08 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS360936: Remove MD5 HMAC from OCF..

Herald added a reviewer: jmg. · View Herald TranscriptMay 11 2020, 10:08 PM

Herald added a reviewer: manpages. · View Herald Transcript

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

share/

man/

man9/

1 line

sys/

crypto/

via/

3 lines

dev/

cesa/

18 lines

glxsb/

1 line

hifn/

9 lines

safe/

34 lines

sec/

8 lines

mips/

cavium/

cryptocteon/

cavium_crypto.c

443 lines

14 lines

cryptocteonvar.h

3 lines

nlm/

dev/

sec/

1 line

4 lines

opencrypto/

3 lines

6 lines

5 lines

1 line

3 lines

3 lines

Diff 71570

share/man/man9/crypto.9

Loading...

sys/crypto/via/padlock_hash.c

Loading...

sys/dev/cesa/cesa.c

Loading...

sys/dev/glxsb/glxsb.c

Loading...

sys/dev/hifn/hifn7751.c

Loading...

sys/dev/safe/safe.c

Loading...

sys/dev/sec/sec.c

Loading...

sys/mips/cavium/cryptocteon/cavium_crypto.c

Loading...

sys/mips/cavium/cryptocteon/cryptocteon.c

Loading...

sys/mips/cavium/cryptocteon/cryptocteonvar.h

Loading...

sys/mips/nlm/dev/sec/nlmsec.c

Loading...

sys/mips/nlm/dev/sec/nlmseclib.c

Loading...

sys/opencrypto/crypto.c

Loading...

sys/opencrypto/cryptodev.h

Loading...

sys/opencrypto/cryptosoft.c

Loading...

sys/opencrypto/xform.h

Loading...

sys/opencrypto/xform.c

Loading...

sys/opencrypto/xform_auth.h

Loading...

sys/opencrypto/xform_md5.c

Loading...