Paths

Table of Contentst

Differential D24775

Remove MD5 HMAC from OCF.
ClosedPublic
Actions

Authored by jhb on May 8 2020, 6:46 PM.

Tags

None

Referenced Files

	F133287934: D24775.diff
	Fri, Oct 24, 3:57 PM

	Unknown Object (File)
	Tue, Oct 21, 11:27 AM

	Unknown Object (File)
	Mon, Oct 20, 11:43 PM

	Unknown Object (File)
	Mon, Oct 20, 1:42 PM

	Unknown Object (File)
	Sun, Oct 19, 11:50 PM

	Unknown Object (File)
	Thu, Oct 9, 9:55 PM

	Unknown Object (File)
	Wed, Oct 8, 4:52 AM

	Unknown Object (File)
	Thu, Sep 25, 2:50 AM

Subscribers

Details

Reviewers

cem
jmg

Group Reviewers

Commits

rS360936: Remove MD5 HMAC from OCF.

Summary

There are no in-kernel consumers.

Test Plan

make tinderbox

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.May 8 2020, 6:46 PM

jhb created this revision.

Harbormaster completed remote builds in B30993: Diff 71570.May 8 2020, 6:46 PM

jhb added a parent revision: D24774: kgssapi no longer supports RC4, so don't list it as a build dependency..May 8 2020, 6:48 PM

Thanks.

sys/mips/cavium/cryptocteon/cavium_crypto.c
464 ↗	(On Diff #71570)	This deserves to be removed for this function name alone
sys/mips/cavium/cryptocteon/cryptocteonvar.h
66 ↗	(On Diff #71570)	Yeah it's almost like they should have names that reflect what they do
sys/opencrypto/cryptodev.h
77 ↗	(On Diff #71570)	I might keep this constant, even if unused. I don't know if this is the best header for it, but given proximity to the other similar values, it seems ok.
90 ↗	(On Diff #71570)	Ditto. Even if we don't use the algorithm in OCF it is occasionally handy to have these numbers as reference points.

This revision is now accepted and ready to land.May 9 2020, 2:22 PM

jhb added inline comments.May 11 2020, 9:41 PM

sys/opencrypto/cryptodev.h
90 ↗	(On Diff #71570)	<sys/md5.h> already has `MD5_DIGEST_LENGTH` and `MD5_BLOCK_LENGTH` and any in-kernel users of MD5 should be using that header and its constants. I'd like to keep this header limited to what OCF uses / supports.

cem added inline comments.May 11 2020, 9:48 PM

sys/opencrypto/cryptodev.h
90 ↗	(On Diff #71570)	perfect.

Closed by commit rS360936: Remove MD5 HMAC from OCF. (authored by jhb). · Explain WhyMay 11 2020, 10:08 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS360936: Remove MD5 HMAC from OCF..

Herald added a reviewer: jmg. · View Herald TranscriptMay 11 2020, 10:08 PM

Herald added a reviewer: manpages. · View Herald Transcript

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

share/

man/

man4/

2 lines

2 lines

man9/

1 line

sys/

crypto/

via/

3 lines

dev/

cesa/

18 lines

glxsb/

1 line

hifn/

9 lines

safe/

34 lines

sec/

8 lines

mips/

cavium/

cryptocteon/

cavium_crypto.c

443 lines

14 lines

cryptocteonvar.h

3 lines

nlm/

dev/

sec/

1 line

4 lines

opencrypto/

3 lines

6 lines

5 lines

1 line

3 lines

3 lines

79 lines

Diff 71665

head/share/man/man4/hifn.4

Loading...

head/share/man/man4/safe.4

Loading...

head/share/man/man9/crypto.9

Loading...

head/sys/crypto/via/padlock_hash.c

Loading...

head/sys/dev/cesa/cesa.c

Loading...

head/sys/dev/glxsb/glxsb.c

Loading...

head/sys/dev/hifn/hifn7751.c

Loading...

head/sys/dev/safe/safe.c

Loading...

head/sys/dev/sec/sec.c

Loading...

head/sys/mips/cavium/cryptocteon/cavium_crypto.c

Loading...

head/sys/mips/cavium/cryptocteon/cryptocteon.c

Loading...

head/sys/mips/cavium/cryptocteon/cryptocteonvar.h

Loading...

head/sys/mips/nlm/dev/sec/nlmsec.c

Loading...

head/sys/mips/nlm/dev/sec/nlmseclib.c

Loading...

head/sys/opencrypto/crypto.c

Loading...

head/sys/opencrypto/cryptodev.h

Loading...

head/sys/opencrypto/cryptosoft.c

Loading...

head/sys/opencrypto/xform.h

Loading...

head/sys/opencrypto/xform.c

Loading...

head/sys/opencrypto/xform_auth.h

Loading...

head/sys/opencrypto/xform_md5.c

Loading...