Page MenuHomeFreeBSD
Differential D24770

Remove support for keyed MD5 and SHA1 authentication hashes.
ClosedPublic
Actions

Authored by jhb on May 8 2020, 6:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 6, 1:55 PM
Unknown Object (File)
Tue, Nov 4, 11:35 PM
Unknown Object (File)
Mon, Nov 3, 5:19 AM
Unknown Object (File)
Fri, Oct 24, 5:48 AM
Unknown Object (File)
Thu, Oct 23, 9:08 PM
Unknown Object (File)
Thu, Oct 23, 10:17 AM
Unknown Object (File)
Thu, Oct 23, 7:08 AM
Unknown Object (File)
Tue, Oct 21, 11:27 AM
View All Files
Subscribers
imp

Details

Reviewers
cem
jmg
Group Reviewers
manpages
Commits
rS360927: Remove support for keyed MD5 and SHA1 authentication hashes.
Summary

They no longer have any in-tree consumers.

Test Plan
  • make tinderbox

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.May 8 2020, 6:43 PM
jhb created this revision.
Harbormaster completed remote builds in B30988: Diff 71565.May 8 2020, 6:43 PM
jhb added a parent revision: D24769: Remove support for the skipjack encryption algorithm..May 8 2020, 6:47 PM
jhb added a child revision: D24771: Remove support for the ARC4 algorithm from OCF..
cem accepted this revision.May 9 2020, 3:23 PM
cem added inline comments.
sys/opencrypto/cryptosoft.c
1343–1344 ↗(On Diff #71565)

Did Matt's zfree() get committed yet? It'd be a nice cleanup for this pattern.

This revision is now accepted and ready to land.May 9 2020, 3:23 PM
jhb added inline comments.May 11 2020, 8:56 PM
sys/opencrypto/cryptosoft.c
1343–1344 ↗(On Diff #71565)

Hmm, looks like it did.

There are many places in IPsec that don't use explicit_bzero either but use plain bzero. Many of those could likely use zfree() as well.

Closed by commit rS360927: Remove support for keyed MD5 and SHA1 authentication hashes. (authored by jhb). · Explain WhyMay 11 2020, 9:05 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS360927: Remove support for keyed MD5 and SHA1 authentication hashes..
Herald added a reviewer: jmg. · View Herald TranscriptMay 11 2020, 9:05 PM
Herald added a reviewer: manpages. · View Herald Transcript
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
head/
share/
man/
man9/
2 lines
sys/
opencrypto/
6 lines
2 lines
63 lines
2 lines
12 lines
12 lines

Diff 71659

View Options

head/share/man/man9/crypto.9

Loading...
View Options

head/sys/opencrypto/crypto.c

Loading...
View Options

head/sys/opencrypto/cryptodev.h

Loading...
View Options

head/sys/opencrypto/cryptosoft.c

Loading...
View Options

head/sys/opencrypto/xform_auth.h

Loading...
View Options

head/sys/opencrypto/xform_md5.c

Loading...
View Options

head/sys/opencrypto/xform_sha1.c

Loading...