Page MenuHomeFreeBSD
Differential D24602

Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6()
ClosedPublic
Actions

Authored by nc on Apr 28 2020, 2:57 AM.
Tags
None
Referenced Files
F103748261: D24602.id71288.diff
Thu, Nov 28, 9:42 PM
Unknown Object (File)
Sun, Nov 24, 2:35 PM
Unknown Object (File)
Wed, Nov 20, 10:44 PM
Unknown Object (File)
Tue, Nov 19, 2:58 PM
Unknown Object (File)
Tue, Nov 19, 12:41 PM
Unknown Object (File)
Tue, Nov 19, 10:36 AM
Unknown Object (File)
Tue, Nov 19, 2:36 AM
Unknown Object (File)
Tue, Nov 19, 12:21 AM
View All 54 Files
Subscribers
ae
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
emaste
rgrimes
tuexen
Commits
rS360594: ipfw: whitespace fix in SCTP_ABORT_ASSOCIATION case statement comment
Summary

Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6(). This ensures consistency with send_reject().

While we're here, fix the grammar in both SCTP_ABORT_ASSOCIATION case comments.

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nc created this revision.Apr 28 2020, 2:57 AM
Herald added subscribers: Contributor Reviews (src), melifaro, ae, imp. · View Herald TranscriptApr 28 2020, 2:57 AM
nc requested review of this revision.Apr 28 2020, 2:57 AM
nc added reviewers: emaste, rgrimes.May 1 2020, 6:38 PM
emaste added a reviewer: tuexen.May 1 2020, 6:43 PM
tuexen accepted this revision.May 1 2020, 7:01 PM

I put is in the way it is now. I agree, this is not consistent with the rest of the file.

This revision is now accepted and ready to land.May 1 2020, 7:01 PM
rgrimes added inline comments.May 2 2020, 5:44 AM
sys/netpfil/ipfw/ip_fw2.c
940 ↗(On Diff #71091)

don't -> do not, and.. do not do what??? This is not a valid sentence, subject of verb do is missing.

tuexen added inline comments.May 2 2020, 8:24 AM
sys/netpfil/ipfw/ip_fw2.c
940 ↗(On Diff #71091)

it should read "but do not do that to avoid attacks". And I guess the same text appears twice in this file. So please fix it twice.

nc updated this revision to Diff 71288.May 2 2020, 4:49 PM
nc edited the summary of this revision. (Show Details)

Thanks for the suggestions. I have made the requested changes here.

This revision now requires review to proceed.May 2 2020, 4:49 PM
nc marked 2 inline comments as done.May 2 2020, 4:50 PM
tuexen accepted this revision.May 2 2020, 5:36 PM
This revision is now accepted and ready to land.May 2 2020, 5:36 PM
rgrimes accepted this revision.May 3 2020, 2:19 AM
Closed by commit rS360594: ipfw: whitespace fix in SCTP_ABORT_ASSOCIATION case statement comment (authored by emaste). · Explain WhyMay 3 2020, 3:44 AM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS360594: ipfw: whitespace fix in SCTP_ABORT_ASSOCIATION case statement comment.

Revision Contents
Changeset List

PathSize
head/
sys/
netpfil/
ipfw/
4 lines

Diff 71316

View Options

head/sys/netpfil/ipfw/ip_fw2.c

Loading...