Page MenuHomeFreeBSD

Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6()
ClosedPublic

Authored by nc on Apr 28 2020, 2:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 2:35 PM
Unknown Object (File)
Wed, Nov 20, 10:44 PM
Unknown Object (File)
Tue, Nov 19, 2:58 PM
Unknown Object (File)
Tue, Nov 19, 12:41 PM
Unknown Object (File)
Tue, Nov 19, 10:36 AM
Unknown Object (File)
Tue, Nov 19, 2:36 AM
Unknown Object (File)
Tue, Nov 19, 12:21 AM
Unknown Object (File)
Mon, Nov 18, 9:51 PM

Details

Summary

Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6(). This ensures consistency with send_reject().

While we're here, fix the grammar in both SCTP_ABORT_ASSOCIATION case comments.

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nc requested review of this revision.Apr 28 2020, 2:57 AM

I put is in the way it is now. I agree, this is not consistent with the rest of the file.

This revision is now accepted and ready to land.May 1 2020, 7:01 PM
sys/netpfil/ipfw/ip_fw2.c
940

don't -> do not, and.. do not do what??? This is not a valid sentence, subject of verb do is missing.

sys/netpfil/ipfw/ip_fw2.c
940

it should read "but do not do that to avoid attacks". And I guess the same text appears twice in this file. So please fix it twice.

nc edited the summary of this revision. (Show Details)

Thanks for the suggestions. I have made the requested changes here.

This revision now requires review to proceed.May 2 2020, 4:49 PM
nc marked 2 inline comments as done.May 2 2020, 4:50 PM
This revision is now accepted and ready to land.May 2 2020, 5:36 PM