Differential D2414

ixgbe: Add X550 device support.
ClosedPublic
Actions

Authored by erj on Apr 30 2015, 6:09 PM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Apr 26, 12:43 PM

	Unknown Object (File)
	Thu, Apr 25, 11:49 PM

	Unknown Object (File)
	Thu, Apr 25, 4:20 PM

	Unknown Object (File)
	Wed, Apr 17, 2:26 AM

	Unknown Object (File)
	Tue, Apr 16, 2:46 AM

	Unknown Object (File)
	Thu, Apr 11, 6:48 PM

	Unknown Object (File)
	Mar 10 2024, 3:09 AM

	Unknown Object (File)
	Jan 25 2024, 6:15 AM

View All 71 Files

Subscribers

Details

Reviewers

jfv
jhb
erj
gnn
adrian

Group Reviewers

Summary

This version of the driver adds support for standalone X550 adapters and the 10Gbase-T/backplane X552/557 devices integrated in Xeon D SoCs. Support for other X550 SKUs will be forthcoming, as they are released.

Test Plan

We've tested our internal version of the driver, and this version of the driver should work. However, we don't do much testing with other features like netmap or other pseudodrivers like lagg, so this may unintentionally break some of that functionality.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

erj updated this revision to Diff 5115.Apr 30 2015, 6:09 PM

erj retitled this revision from to ixgbe: Add X550 device support..

erj updated this object.

erj edited the test plan for this revision. (Show Details)

erj added reviewers: jfv, gnn.

erj set the repository for this revision to rS FreeBSD src repository - subversion.

erj added a project: network.

erj added a subscriber: adrian.

Herald added a reviewer: manpages. · View Herald TranscriptApr 30 2015, 6:09 PM

Herald added a subscriber: imp. · View Herald Transcript

The man page / README needs updating, to describe the new sysctls and functionality.

adrian accepted this revision.Apr 30 2015, 6:16 PM

adrian added a reviewer: adrian.

adrian added inline comments.

sys/dev/ixgbe/if_ix.c
2792	The reason I #if 0'ed these out is so it's really obvious to people who /want/ 4-tuple UDP hashing what they need to do.
2831	Instead of having an if for the index_mult and then a switch statement below, fold both the mult and the table size into one switch statement?

This revision is now accepted and ready to land.Apr 30 2015, 6:16 PM

erj added a reviewer: jhb.Apr 30 2015, 6:35 PM

Please update the 2014 copyright before committing, but, otherwise, looks good.

sys/dev/ixgbe/ixgbe_x550.h
4	It is now 2015.

Made changes suggested by @adrian and changed the copyright to 2015 in all the files.

This revision now requires review to proceed.Apr 30 2015, 9:57 PM

erj mentioned this in rS282289: Add support for certain Intel X550 devices..Apr 30 2015, 10:53 PM

erj mentioned this in rS282290: Include makefiles necessary to make ixgbe build with the new code..Apr 30 2015, 10:56 PM

erj accepted this revision.May 7 2015, 6:00 PM

erj added a reviewer: erj.

This revision is now accepted and ready to land.May 7 2015, 6:00 PM

erj closed this revision.May 7 2015, 6:00 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixgbe/

1058 lines

9 lines

57 lines

39 lines

2 lines

7 lines

2 lines

6 lines

11 lines

122 lines

2 lines

6 lines

2 lines

12 lines

ixgbe_dcb_82598.h

2 lines

ixgbe_dcb_82598.c

2 lines

ixgbe_dcb_82599.h

2 lines

ixgbe_dcb_82599.c

2 lines

2 lines

4 lines

9 lines

23 lines

228 lines

265 lines

2 lines

3 lines

2 lines

12 lines

109 lines

3191 lines

modules/

ix/

2 lines

ixv/

2 lines

Diff 5124

sys/dev/ixgbe/if_ix.c

Loading...

sys/dev/ixgbe/if_ixv.c

Loading...

sys/dev/ixgbe/ix_txrx.c

Loading...

sys/dev/ixgbe/ixgbe.h

Loading...

sys/dev/ixgbe/ixgbe_82598.h

Loading...

sys/dev/ixgbe/ixgbe_82598.c

Loading...

sys/dev/ixgbe/ixgbe_82599.h

Loading...

sys/dev/ixgbe/ixgbe_82599.c

Loading...

sys/dev/ixgbe/ixgbe_api.h

Loading...

sys/dev/ixgbe/ixgbe_api.c

Loading...

sys/dev/ixgbe/ixgbe_common.h

Loading...

sys/dev/ixgbe/ixgbe_common.c

Loading...

sys/dev/ixgbe/ixgbe_dcb.h

Loading...

sys/dev/ixgbe/ixgbe_dcb.c

Loading...

sys/dev/ixgbe/ixgbe_dcb_82598.h

Loading...

sys/dev/ixgbe/ixgbe_dcb_82598.c

Loading...

sys/dev/ixgbe/ixgbe_dcb_82599.h

Loading...

sys/dev/ixgbe/ixgbe_dcb_82599.c

Loading...

sys/dev/ixgbe/ixgbe_mbx.h

Loading...

sys/dev/ixgbe/ixgbe_mbx.c

Loading...

sys/dev/ixgbe/ixgbe_osdep.h

Loading...

sys/dev/ixgbe/ixgbe_phy.h

Loading...

sys/dev/ixgbe/ixgbe_phy.c

Loading...

sys/dev/ixgbe/ixgbe_type.h

Loading...

sys/dev/ixgbe/ixgbe_vf.h

Loading...

sys/dev/ixgbe/ixgbe_vf.c

Loading...

sys/dev/ixgbe/ixgbe_x540.h

Loading...

sys/dev/ixgbe/ixgbe_x540.c

Loading...

sys/dev/ixgbe/ixgbe_x550.h

Loading...

sys/dev/ixgbe/ixgbe_x550.c

Loading...

sys/modules/ix/Makefile

Loading...

sys/modules/ixv/Makefile

Loading...