Page MenuHomeFreeBSD

[PPC][Book-E] Fix missing load base in elf_cpu_parse_dynamic
ClosedPublic

Authored by bdragon on Tue, Mar 17, 10:10 PM.

Details

Summary

When I implemented MD DYNAMIC parsing, I was originally passing a linker_file_t so that the MD code could relocate pointers.

However, it turns out this isn't even filled in until later, so it was always 0.

Just pass the load base (ef->address) directly, as that's really the only thing we were interested in in the first place.

Fixes a crash on RB800 where it was trying to write to an unmapped address when updating the GOT.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bdragon created this revision.Tue, Mar 17, 10:10 PM
jhibbits accepted this revision.Wed, Mar 18, 1:29 AM
This revision is now accepted and ready to land.Wed, Mar 18, 1:29 AM