bridge tests: Basic span test
ClosedPublic
Actions

Authored by kp on Mar 4 2020, 6:11 PM.

Details

Reviewers

emaste
philip

Group Reviewers

network

Commits

rGc4bf12b43711: bridge tests: Basic span test
rS359010: bridge tests: Basic span test

Summary

Diff Detail

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	tests/sys/net/if_bridge_test.sh:	CHMOD1	Invalid Executable

Unit

No Test Coverage

Build Status

Buildable 29853
Build 27677: arc lint + arc unit

Event Timeline

kp created this revision.Mar 4 2020, 6:11 PM

Herald added subscribers: melifaro, ae. · View Herald TranscriptMar 4 2020, 6:11 PM

Harbormaster completed remote builds in B29787: Diff 69171.Mar 4 2020, 6:11 PM

Isn't this test always going to succeed as long as the span can be removed? Or am I misunderstanding something?

The primary use case for the test is to see if WITNESS or INVARIANTS complain about something, so in that respect at least the test is useful to have.
It would be good to check that the span actually shows traffic though. I'll see if I can repurpose pft_ping.py for this. That should let us send a ping through one interface and verify that we see it on the span interface.

I think adding a test that some traffic actually passes is worthwhile, and probably a comment too about checking for WITNESS/INVARIANTS warnings (since the test does not do that programmatically).

Actually check for traffic on the span interface

Harbormaster completed remote builds in B29853: Diff 69325.Mar 9 2020, 2:15 PM

In D23961#527398, @emaste wrote:

I think adding a test that some traffic actually passes is worthwhile, and probably a comment too about checking for WITNESS/INVARIANTS warnings (since the test does not do that programmatically).

That's implicit. We do that in a lot of tests. An INVARIANTS violation is pretty obvious anyway.

Ping. Any remarks on the updated version?

Looks good to me. Thank you!

This revision is now accepted and ready to land.Mar 15 2020, 2:39 AM

This revision was landed with ongoing or failed builds.Mar 16 2020, 8:45 AM

Closed by commit rS359010: bridge tests: Basic span test (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rS359010: bridge tests: Basic span test.

Herald added a subscriber: imp. · View Herald TranscriptMar 16 2020, 8:45 AM

kp added a commit: rGc4bf12b43711: bridge tests: Basic span test.Mar 2 2021, 3:19 PM