Page MenuHomeFreeBSD

make lacp's use_numa hashing aware of send tags
ClosedPublic

Authored by gallatin on Feb 23 2020, 9:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 28, 9:18 PM
Unknown Object (File)
Tue, Sep 23, 1:39 PM
Unknown Object (File)
Sep 5 2025, 5:08 PM
Unknown Object (File)
Aug 26 2025, 11:19 AM
Unknown Object (File)
Aug 4 2025, 2:26 PM
Unknown Object (File)
Jul 29 2025, 10:24 AM
Unknown Object (File)
Jul 22 2025, 12:16 PM
Unknown Object (File)
Jul 7 2025, 12:26 AM
Subscribers

Details

Reviewers
hselasky
jhb
rrs
Group Reviewers
transport
Summary

When I did the use_numa support, I missed the fact that there is a separate hash function for send tag nic selection. So when use_numa is enabled, ktls offload does not work properly, as it dos not reliably allocate a send tag on the proper egress nic since different egress nics are selected for send-tag allocation and packet transmit. To fix this, this change:

  • refectors lacp_select_tx_port_by_hash() and lacp_select_tx_port() to make lacp_select_tx_port_by_hash() always called by lacp_select_tx_port()
  • pre-shifts flowids to convert them to hashes when calling lacp_select_tx_port_by_hash()
  • add a numa_domain field to if_snd_tag_alloc_params
  • plumb the numa domain into places where we allocate send tags

In testing with NIC TLS setup on a NUMA machine, I see thousands of output errors before the patch when enabling kern.ipc.tls.ifnet.permitted=1. After the change, I see no errors, and I see the NIC sysctl counters showing active TLS offload sessions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 29561