Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic
Actions

Authored by kaktus on Feb 11 2020, 9:02 PM.

Details

Reviewers

kib

Group Reviewers

bhyve

Commits

rS357974: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (4 of many)

Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kaktus created this revision.Feb 11 2020, 9:02 PM

Herald added subscribers: bcran, rgrimes. · View Herald TranscriptFeb 11 2020, 9:02 PM

kaktus edited the summary of this revision. (Show Details)Feb 11 2020, 9:04 PM

I believe all sysctls in vmm/ can be safely marked as MPSAFE.

Mark the nodes as MPSAFE.

Again, wait some limited time for somebody from bhyve, then commit.

This revision is now accepted and ready to land.Feb 13 2020, 5:01 PM

Generally looks fine. Only weirdness is having to mark SYSCTL_NODE()'s with MPSAFE. A SYSCTL_NODE without an explicit handler (so handler set to NULL) is inherently MPSAFE, and it'd be nice to adjust the assertions to special case that to avoid adding churn since eventually once al sysctls are safe we will go through and remove all the CTLFLAG_MPSAFE flags.