Page MenuHomeFreeBSD

Add missing EPOCH(9) wrapper in ipfw
ClosedPublic

Authored by hselasky on Mon, Feb 10, 9:13 AM.

Details

Summary

Backtrace:
panic()
ip_output()
dyn_tick()
softclock_call_cc()
softclock()
ithread_loop()

Found by: mmacy@
Reported by: jmd@
Sponsored by: Mellanox Technologies

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hselasky created this revision.Mon, Feb 10, 9:13 AM
hselasky edited the summary of this revision. (Show Details)Mon, Feb 10, 9:14 AM
hselasky added a reviewer: mmacy.
ae accepted this revision.Mon, Feb 10, 10:26 AM
This revision is now accepted and ready to land.Mon, Feb 10, 10:26 AM

Thanks for the find. I'd rather move the entrance to dyn_tick(). Would use less lines of code and would make it easier to spot it later, when we have callouts supporting epoch.

hselasky updated this revision to Diff 68095.Mon, Feb 10, 8:51 PM
hselasky retitled this revision from Add missing EPOCH wrappers in firewall code to Add missing EPOCH(9) wrapper in ipfw.
This revision now requires review to proceed.Mon, Feb 10, 8:51 PM

@glebius: Looks better now?

glebius accepted this revision.Tue, Feb 11, 6:09 PM
This revision is now accepted and ready to land.Tue, Feb 11, 6:09 PM
This revision was automatically updated to reflect the committed changes.