Page MenuHomeFreeBSD

Don't enable interrupts in init_secondary().
ClosedPublic

Authored by markj on Jan 22 2020, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 7:36 PM
Unknown Object (File)
Thu, Oct 2, 3:22 AM
Unknown Object (File)
Wed, Sep 17, 12:18 PM
Unknown Object (File)
Sep 3 2025, 1:56 PM
Unknown Object (File)
Jul 23 2025, 10:38 AM
Unknown Object (File)
Jul 5 2025, 3:32 AM
Unknown Object (File)
Jul 4 2025, 7:27 AM
Unknown Object (File)
Jun 17 2025, 5:47 PM
Subscribers

Details

Summary

Doing so can cause deadlocks or panics during boot. In QEMU I was
seeing occasional panics during boot when a statclock interrupt
interrupted an idle thread in init_secondary(), before per-CPU scheduler
data structures were linked. It also seemed to be causing some
mysterious boot failures in AWS but I don't have console access and so
cannot confirm.

The idle threads are set up to release a spinlock section and enable
interrupts in fork_exit(), so there is no need to enable interrupts
earlier.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable