Page MenuHomeFreeBSD

random(3): Abstract routines into _r versions on explicit state
ClosedPublic

Authored by cem on Jan 21 2020, 2:07 AM.
Tags
None
Referenced Files
F141286449: D23289.id.diff
Sat, Jan 3, 2:32 PM
Unknown Object (File)
Sat, Jan 3, 4:14 AM
Unknown Object (File)
Thu, Jan 1, 12:24 PM
Unknown Object (File)
Thu, Jan 1, 9:22 AM
Unknown Object (File)
Tue, Dec 30, 11:39 AM
Unknown Object (File)
Mon, Dec 29, 7:49 PM
Unknown Object (File)
Sat, Dec 27, 3:40 PM
Unknown Object (File)
Mon, Dec 22, 3:05 PM
Subscribers

Details

Summary

The existing APIs simply pass the implicit global state to the _r variants.

No functional change.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28804
Build 26813: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 21 2020, 6:11 PM

I had some concerns about providing *_r variants of these that match names from glibc but aren't compatible, but I see the ultimate plan is that these aren't intended to be exported from libc at all- this seems OK.

I had some concerns about providing *_r variants of these that match names from glibc but aren't compatible, but I see the ultimate plan is that these aren't intended to be exported from libc at all- this seems OK.

Hm, I didn't realize glibc had these routines. They picked different argument orderings and state struct name (and field names), but otherwise look pretty similar. Yeah, I didn't intend to export these routines from libc and don't see a great reason to.