Differential D23289

random(3): Abstract routines into _r versions on explicit state
ClosedPublic
Actions

Authored by cem on Jan 21 2020, 2:07 AM.

Tags

None

Referenced Files

	F152908203: D23289.id67079.diff
	Fri, Apr 17, 11:13 PM

	Unknown Object (File)
	Thu, Apr 16, 7:49 PM

	Unknown Object (File)
	Wed, Apr 15, 7:57 PM

	Unknown Object (File)
	Sun, Apr 12, 4:11 AM

	Unknown Object (File)
	Sat, Apr 11, 7:39 PM

	Unknown Object (File)
	Fri, Apr 10, 2:08 PM

	Unknown Object (File)
	Thu, Apr 9, 2:42 AM

	Unknown Object (File)
	Wed, Apr 8, 8:21 PM

Subscribers

Details

Reviewers

jilles
kevans
vangyzen
markm

Group Reviewers

Commits

rS357066: random(3): Abstract routines into _r versions on explicit state

Summary

The existing APIs simply pass the implicit global state to the _r variants.

No functional change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Jan 21 2020, 2:07 AM

Harbormaster completed remote builds in B28804: Diff 67079.Jan 21 2020, 2:07 AM

cem added a parent revision: D23288: random(3): Abstract state into a single context object.Jan 21 2020, 2:09 AM

cem added a child revision: D23290: rand(3): Replace implementation with one backed by random(3) algorithm.

markm accepted this revision.Jan 21 2020, 6:11 PM

This revision is now accepted and ready to land.Jan 21 2020, 6:11 PM

I had some concerns about providing *_r variants of these that match names from glibc but aren't compatible, but I see the ultimate plan is that these aren't intended to be exported from libc at all- this seems OK.

In D23289#510876, @kevans wrote:

I had some concerns about providing *_r variants of these that match names from glibc but aren't compatible, but I see the ultimate plan is that these aren't intended to be exported from libc at all- this seems OK.

Hm, I didn't realize glibc had these routines. They picked different argument orderings and state struct name (and field names), but otherwise look pretty similar. Yeah, I didn't intend to export these routines from libc and don't see a great reason to.

Closed by commit rS357066: random(3): Abstract routines into _r versions on explicit state (authored by cem). · Explain WhyJan 24 2020, 1:39 AM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS357066: random(3): Abstract routines into _r versions on explicit state.

Herald added a subscriber: imp. · View Herald TranscriptJan 24 2020, 1:39 AM

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

stdlib/

46 lines

196 lines

Diff 67234

head/lib/libc/stdlib/random.h

Loading...

head/lib/libc/stdlib/random.c

Loading...