Paths

Table of Contentst

Differential D23123

retire LLVM_LIBUNWIND option
ClosedPublic
Actions

Authored by emaste on Jan 10 2020, 5:25 PM.

Tags

None

Referenced Files

	F81642677: D23123.id68644.diff
	Fri, Apr 19, 9:46 AM

	F81621042: D23123.id66685.diff
	Fri, Apr 19, 2:47 AM

	F81620312: D23123.id66592.diff
	Fri, Apr 19, 2:28 AM

	Unknown Object (File)
	Wed, Apr 17, 7:53 AM

	Unknown Object (File)
	Wed, Apr 17, 7:53 AM

	Unknown Object (File)
	Wed, Apr 17, 7:53 AM

	Unknown Object (File)
	Wed, Apr 17, 7:47 AM

	Unknown Object (File)
	Wed, Apr 17, 7:47 AM

View All 46 Files

Subscribers

Details

Reviewers

imp
cem
jhb
brooks

Commits

rS358460: retire the LLVM_LIBUNWIND option

Summary

LLVM's libunwind is (will be) used on all CPU architectures.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Jan 10 2020, 5:25 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptJan 10 2020, 5:25 PM

emaste added reviewers: imp, cem, jhb.Jan 10 2020, 5:31 PM

emaste added inline comments.

lib/Makefile
181–182	move these into the main list (but I need to make sure there isn't some ordering problem)
share/mk/src.opts.mk
393–394	oops this PR reference should go too
targets/pseudo/userland/gnu/Makefile.depend
40–41	not sure why this empty block is here, it could be cleaned up now

brooks accepted this revision.Jan 10 2020, 10:13 PM

brooks added a subscriber: brooks.

brooks added inline comments.

lib/Makefile
181–182	Hmm, moving this up to line 101 should be safe since everything between doesn't add to SUBDIR or is added later as SUBDIR.yes. IIRC, we do have an occasional race involving libgcc_s IIRC, but I don't think anyone has managed to track it down.

This revision is now accepted and ready to land.Jan 10 2020, 10:13 PM

move libgcc_eh/libgcc_s into main list

This revision now requires review to proceed.Jan 13 2020, 2:46 PM

rebase
add UPDATING

This revision was not accepted when it landed; it landed in state Needs Review.Feb 29 2020, 12:44 PM

Closed by commit rS358460: retire the LLVM_LIBUNWIND option (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS358460: retire the LLVM_LIBUNWIND option.

Revision Contents
Changeset List

Path

Size

4 lines

4 lines

contrib/

bmake/

mk/

1 line

lib/

4 lines

share/

mk/

local.dirdeps.mk

4 lines

local.gendirdeps.mk

1 line

1 line

7 lines

targets/

pseudo/

userland/

gnu/

Makefile.depend

3 lines

lib/

Makefile.depend

2 lines

tools/

build/

options/

WITHOUT_LLVM_LIBUNWIND

WITH_LLVM_LIBUNWIND

Diff 68644

Makefile.inc1

Loading...

UPDATING

Loading...

contrib/bmake/mk/meta2deps.sh

Loading...

lib/Makefile

Loading...

share/mk/local.dirdeps.mk

Loading...

share/mk/local.gendirdeps.mk

Loading...

share/mk/meta2deps.sh

Loading...

share/mk/src.opts.mk

Loading...

targets/pseudo/userland/gnu/Makefile.depend

Loading...

targets/pseudo/userland/lib/Makefile.depend

Loading...

tools/build/options/WITHOUT_LLVM_LIBUNWIND

Loading...

tools/build/options/WITH_LLVM_LIBUNWIND

Loading...