Page MenuHomeFreeBSD

sysctl: mark more nodes as MPSAFE
ClosedPublic

Authored by kaktus on Jan 5 2020, 10:28 AM.

Details

Summary

vm.kvm_size and vm.kvm_free are read only and marked as MPSAFE on i386 already. Mark them as that on amd64 and arm64 too to avoid locking Giant.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kaktus created this revision.Jan 5 2020, 10:28 AM
kib accepted this revision.Jan 6 2020, 12:53 AM

Due to resurrected efforts to get rid of Giant, It might be worth to make add a flag now to mark non-mpsafe sysctls, and remove CFLFLAG_MPSAFE. I am not sure how huge the work itself, and the churn, would be.

This revision is now accepted and ready to land.Jan 6 2020, 12:53 AM
This revision was automatically updated to reflect the committed changes.