sysctl: mark more nodes as MPSAFE
ClosedPublic
Actions

Authored by kaktus on Jan 5 2020, 10:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 28, 2:18 AM

	Unknown Object (File)
	Tue, Oct 28, 2:18 AM

	Unknown Object (File)
	Tue, Oct 28, 2:18 AM

	Unknown Object (File)
	Mon, Oct 27, 8:30 PM

	Unknown Object (File)
	Tue, Oct 14, 2:35 AM

	Unknown Object (File)
	Sep 30 2025, 5:04 AM

	Unknown Object (File)
	Sep 29 2025, 3:41 PM

	Unknown Object (File)
	Sep 29 2025, 3:41 PM

Subscribers

Details

Reviewers

kib
mjg
manu

Commits

rS356413: sysctl: mark more nodes as MPSAFE

Summary

vm.kvm_size and vm.kvm_free are read only and marked as MPSAFE on i386 already. Mark them as that on amd64 and arm64 too to avoid locking Giant.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kaktus created this revision.Jan 5 2020, 10:28 AM

Herald added a reviewer: manu. · View Herald TranscriptJan 5 2020, 10:28 AM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

val_packett.cool added a subscriber: val_packett.cool.Jan 5 2020, 12:10 PM

Due to resurrected efforts to get rid of Giant, It might be worth to make add a flag now to mark non-mpsafe sysctls, and remove CFLFLAG_MPSAFE. I am not sure how huge the work itself, and the churn, would be.

This revision is now accepted and ready to land.Jan 6 2020, 12:53 AM

Closed by commit rS356413: sysctl: mark more nodes as MPSAFE (authored by kaktus). · Explain WhyJan 6 2020, 10:52 AM

This revision was automatically updated to reflect the committed changes.

kaktus added a commit: rS356413: sysctl: mark more nodes as MPSAFE.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

pmap.c

10 lines

arm64/

pmap.c

10 lines

Diff 66405

View Options

head/sys/amd64/amd64/pmap.c