Page MenuHomeFreeBSD
Differential D22972

Add basic getcpu(2) support to linuxulator
ClosedPublic
Actions

Authored by trasz on Dec 30 2019, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 9:33 AM
Unknown Object (File)
Fri, Dec 6, 10:28 PM
Unknown Object (File)
Nov 21 2024, 9:23 AM
Unknown Object (File)
Oct 23 2024, 2:20 AM
Unknown Object (File)
Sep 23 2024, 3:42 PM
Unknown Object (File)
Sep 20 2024, 10:38 PM
Unknown Object (File)
Sep 17 2024, 12:33 PM
Unknown Object (File)
Sep 8 2024, 4:58 PM
View All 65 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
brooks
emaste
dchagin
kib
Group Reviewers
Linux Emulation
Commits
rS356241: Add basic getcpu(2) support to linuxulator. The purpose of this
Summary

Add basic getcpu(2) support to linuxulator. This unbreaks
Java from CentOS 8 (java-11-openjdk-11.0.5.10-0.el8_0.x86_64).

The purpose of this syscall is to query the CPU number and the NUMA
domain the calling thread is currently running on. The third argument
is ignored. It doesn't do anything regarding scheduling - it's literally
just a way to query the current state, without any guarantees you won't
get rescheduled an opcode later.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Dec 30 2019, 7:43 PM
Herald added a reviewer: manu. · View Herald TranscriptDec 30 2019, 7:43 PM
Herald added a reviewer: brooks. · View Herald Transcript
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
Harbormaster completed remote builds in B28385: Diff 66150.Dec 30 2019, 7:43 PM
trasz added reviewers: Linux Emulation, emaste, dchagin, kib.Dec 30 2019, 7:44 PM
kib added a comment.Dec 30 2019, 8:15 PM

In review summary, please explain the syscall interface.

trasz edited the summary of this revision. (Show Details)Dec 30 2019, 8:54 PM
kib added inline comments.Dec 31 2019, 1:18 AM
sys/compat/linux/linux_misc.c
2366 ↗(On Diff #66150)

copyout reads the source byte-by-byte. This means that if the thread is rescheduled during copyout, the result might contain cpu number for non-existing cpu.

trasz updated this revision to Diff 66180.Dec 31 2019, 11:13 AM
trasz edited the summary of this revision. (Show Details)

Use local copy for cpu.

trasz marked an inline comment as done.Dec 31 2019, 11:14 AM
Harbormaster completed remote builds in B28400: Diff 66180.Dec 31 2019, 11:14 AM
kib accepted this revision.Dec 31 2019, 12:38 PM

Exclude the generated files from commit.

This revision is now accepted and ready to land.Dec 31 2019, 12:38 PM
trasz updated this revision to Diff 66187.Dec 31 2019, 4:14 PM

Regen after committing definitions fixes.

This revision now requires review to proceed.Dec 31 2019, 4:14 PM
Harbormaster completed remote builds in B28403: Diff 66187.Dec 31 2019, 4:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 31 2019, 10:01 PM
Closed by commit rS356241: Add basic getcpu(2) support to linuxulator. The purpose of this (authored by trasz). · Explain Why
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS356241: Add basic getcpu(2) support to linuxulator. The purpose of this.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
linux/
2 lines
linux32/
2 lines
arm64/
linux/
2 lines
compat/
linux/
16 lines
i386/
linux/
2 lines

Diff 66197

View Options

head/sys/amd64/linux/linux_dummy.c

Loading...
View Options

head/sys/amd64/linux32/linux32_dummy.c

Loading...
View Options

head/sys/arm64/linux/linux_dummy.c

Loading...
View Options

head/sys/compat/linux/linux_misc.c

Loading...
View Options

head/sys/i386/linux/linux_dummy.c

Loading...