Tested on: amd64 (linux64 only), i386
Details
Details
- Reviewers
emaste manu - Commits
- rS354754: Use a sv_copyout_auxargs hook in the Linux ELF ABIs.
- I have not tested on arm64
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/amd64/linux/linux_sysvec.c | ||
|---|---|---|
| 332 ↗ | (On Diff #64293) | This had to be moved earlier as the auxv entries have to be right after the end of the argv and envv arrays. I originally hadn't moved this which broke as the extra 8 byte gap was between the end of argv and the auxv array. |
Comment Actions
I think it's fine to just commit after review, and I'll test it as soon as I can (after commit).
| head/sys/arm64/linux/linux_sysvec.c | ||
|---|---|---|
| 275 | While adding error checking for a followup for @kib, I noticed this line. This is almost certainly going to cause breakage on arm64 with this change. Previously this was overwritten because we recalculated the location of auxargs and the first auxarg overwrote this duplicate argc, but now this argc will be "real", so if arm64 Linux binaries fail, the first thing I'd try is to remove this line. Note that ps_argvstr is also currently wrong (it points at this argc value instead of argv[0]) due to this. | |