Page MenuHomeFreeBSD

Combine ELF sysvecs for MIPS to reduce code duplication.
ClosedPublic

Authored by jhb on Nov 13 2019, 11:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 14, 7:45 PM
Unknown Object (File)
Sat, Nov 1, 3:31 PM
Unknown Object (File)
Sat, Nov 1, 1:51 PM
Unknown Object (File)
Sat, Nov 1, 6:04 AM
Unknown Object (File)
Sat, Nov 1, 4:49 AM
Unknown Object (File)
Fri, Oct 31, 7:59 PM
Unknown Object (File)
Oct 25 2025, 2:18 PM
Unknown Object (File)
Oct 21 2025, 10:37 AM
Subscribers

Details

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/mips/mips/elf_machdep.c
54 ↗(On Diff #64294)

Should this be __elfN(freebsd_sysvec) to match the things below and preserve the name of the public symbol?

sys/mips/mips/elf_machdep.c
54 ↗(On Diff #64294)

It doesn't have to be, and really it could be a static variable instead of a global. It's just passed as the pointer in the .sysvec array, there aren't any other references to it. Note that the brand info is called 'freebsd_brand_info' instead of 'freebsd32/64_brand_info'. Ironically, sparc64 gets this right and marks it static. Looks like i386 does have a few other references to the elf32_freebsd_sysvec for some one-off special cases and that the lack of static was just copied from i386 to other platforms due to cargo cult.

It's probably worth making elf_freebsd_sysvec static, but this is fine.

This revision is now accepted and ready to land.Nov 15 2019, 6:14 PM

I will make it static for commit.