Page MenuHomeFreeBSD

Combine ELF sysvecs for MIPS to reduce code duplication.
ClosedPublic

Authored by jhb on Nov 13 2019, 11:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 3:55 AM
Unknown Object (File)
Dec 18 2023, 2:34 PM
Unknown Object (File)
Nov 5 2023, 1:24 AM
Unknown Object (File)
Nov 4 2023, 11:58 PM
Unknown Object (File)
Oct 4 2023, 1:26 AM
Unknown Object (File)
Oct 4 2023, 12:11 AM
Unknown Object (File)
Sep 30 2023, 1:25 AM
Unknown Object (File)
Sep 26 2023, 5:39 PM
Subscribers

Details

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/mips/mips/elf_machdep.c
54 ↗(On Diff #64294)

Should this be __elfN(freebsd_sysvec) to match the things below and preserve the name of the public symbol?

sys/mips/mips/elf_machdep.c
54 ↗(On Diff #64294)

It doesn't have to be, and really it could be a static variable instead of a global. It's just passed as the pointer in the .sysvec array, there aren't any other references to it. Note that the brand info is called 'freebsd_brand_info' instead of 'freebsd32/64_brand_info'. Ironically, sparc64 gets this right and marks it static. Looks like i386 does have a few other references to the elf32_freebsd_sysvec for some one-off special cases and that the lack of static was just copied from i386 to other platforms due to cargo cult.

It's probably worth making elf_freebsd_sysvec static, but this is fine.

This revision is now accepted and ready to land.Nov 15 2019, 6:14 PM

I will make it static for commit.