Tested on: mips, mips64
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/mips/mips/elf_machdep.c | ||
---|---|---|
54 ↗ | (On Diff #64294) | Should this be __elfN(freebsd_sysvec) to match the things below and preserve the name of the public symbol? |
sys/mips/mips/elf_machdep.c | ||
---|---|---|
54 ↗ | (On Diff #64294) | It doesn't have to be, and really it could be a static variable instead of a global. It's just passed as the pointer in the .sysvec array, there aren't any other references to it. Note that the brand info is called 'freebsd_brand_info' instead of 'freebsd32/64_brand_info'. Ironically, sparc64 gets this right and marks it static. Looks like i386 does have a few other references to the elf32_freebsd_sysvec for some one-off special cases and that the lack of static was just copied from i386 to other platforms due to cargo cult. |