Page MenuHomeFreeBSD

Add linux_skip_mounts
ClosedPublic

Authored by trasz on Nov 11 2019, 10:06 PM.
Tags
None
Referenced Files
F112468085: D22320.id64210.diff
Tue, Mar 18, 10:25 AM
Unknown Object (File)
Sun, Mar 16, 7:29 PM
Unknown Object (File)
Sat, Mar 8, 8:02 PM
Unknown Object (File)
Mon, Mar 3, 1:56 PM
Unknown Object (File)
Wed, Feb 26, 9:59 PM
Unknown Object (File)
Sat, Feb 22, 3:32 PM
Unknown Object (File)
Fri, Feb 21, 8:22 AM
Unknown Object (File)
Jan 18 2025, 8:06 AM
Subscribers

Details

Summary

Add 'linux_skip_mounts' rc.conf(5) variable, to avoid mounting
Linux-specific filesystems under /compat/linux when 'linux_enable'
is set to YES.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27470
Build 25704: arc lint + arc unit

Event Timeline

Looks good to me. I've already added linux_skip_mounts=YES to my rc.conf so when I upgrade to 13 I won't forget to do it. :)

This revision is now accepted and ready to land.Nov 11 2019, 10:17 PM

Under the assumption that the man page update will be added to https://reviews.freebsd.org/D22277: OK

I'm not 100% sure but I think all the variables in rc.conf are "positive", not "negative", like enable, never disable. So perhaps the variable should be called linux_mounts or linux_mounts_enable or linux_fs_mount or something, and default to YES.

Rename to 'linux_mounts_enable' and flip the meaning.

This revision now requires review to proceed.Nov 12 2019, 3:03 PM
In D22320#488259, @tijl wrote:

I'm not 100% sure but I think all the variables in rc.conf are "positive", not "negative", like enable, never disable.

Yes, we should avoid negative-sense controls, for sysctls as well.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 13 2019, 8:27 PM
This revision was automatically updated to reflect the committed changes.