Page MenuHomeFreeBSD

Improve Linuxulator man pages
ClosedPublic

Authored by trasz on Thu, Nov 7, 6:18 PM.

Details

Summary

Improve Linuxulator man pages to better reflect the current state.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz created this revision.Thu, Nov 7, 6:18 PM
emaste added a subscriber: emaste.Thu, Nov 7, 7:08 PM
emaste added inline comments.
share/man/man4/linux.4
55–57 ↗(On Diff #64049)

It probably is worth leaving in some statment about this not being 100%

trasz updated this revision to Diff 64068.Fri, Nov 8, 11:14 AM

Add BUGS.

trasz marked an inline comment as done.Fri, Nov 8, 11:14 AM

That's true; I've added a BUGS section.

tijl added inline comments.Mon, Nov 11, 1:28 PM
share/man/man4/linux.4
78 ↗(On Diff #64068)

s/compat/emulators/

trasz updated this revision to Diff 64178.Mon, Nov 11, 3:07 PM

Apply feedback from emaste@ and tijl@.

trasz marked an inline comment as done.Mon, Nov 11, 3:07 PM
brueffer added inline comments.
share/man/man4/linux.4
78 ↗(On Diff #64178)

We mark up ports paths with .Pa if I recall correctly.

84 ↗(On Diff #64178)

Unneeded .Pp, this macro has no effect before/after .Sh

trasz updated this revision to Diff 64183.Mon, Nov 11, 4:05 PM

Feedback from brueffer@.

trasz marked 2 inline comments as done.Mon, Nov 11, 4:05 PM

Fixed, thanks!

brueffer accepted this revision.Mon, Nov 11, 4:51 PM
This revision is now accepted and ready to land.Mon, Nov 11, 4:51 PM
emaste accepted this revision.Mon, Nov 11, 9:38 PM

LGTM

netchild requested changes to this revision.Tue, Nov 12, 10:32 AM
netchild added a subscriber: netchild.

Please add something about linux_skip_mounts from https://reviews.freebsd.org/D22320

This revision now requires changes to proceed.Tue, Nov 12, 10:33 AM
trasz updated this revision to Diff 64229.Tue, Nov 12, 3:06 PM

Document linux_mounts_enable.

tijl added inline comments.Wed, Nov 13, 10:05 AM
share/man/man4/linux.4
85 ↗(On Diff #64229)

The linux_base ports run some Linux programs on installation, e.g. Linux ldconfig to create /compat/linux/etc/ld.so.cache. So I would change the order here. First add linux_enable to /etc/rc.conf, then enable Linux compatibility using 'service linux start', and then install linux_base-c7. That also means that /etc/rc.d/linux should create /compat/linux and /compat/linux/{dev,proc,sys} before mounting file systems because these directories might not exist.

trasz added inline comments.Wed, Nov 13, 1:06 PM
share/man/man4/linux.4
85 ↗(On Diff #64229)

Good point, but can... we move it to another review? What you're suggesting also touches the rc script itself, and there might be different ways it could be solved.

tijl added inline comments.Wed, Nov 13, 2:35 PM
share/man/man4/linux.4
85 ↗(On Diff #64229)

Sure.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Nov 13, 8:32 PM
This revision was automatically updated to reflect the committed changes.
trasz added inline comments.Wed, Nov 13, 8:32 PM
share/man/man4/linux.4
85 ↗(On Diff #64229)