Page MenuHomeFreeBSD
Differential D22277

Improve Linuxulator man pages
ClosedPublic
Actions

Authored by trasz on Nov 7 2019, 6:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 30 2024, 11:50 AM
Unknown Object (File)
Oct 18 2024, 2:12 AM
Unknown Object (File)
Oct 17 2024, 8:45 PM
Unknown Object (File)
Oct 2 2024, 8:08 PM
Unknown Object (File)
Oct 2 2024, 4:37 AM
Unknown Object (File)
Oct 1 2024, 10:09 AM
Unknown Object (File)
Oct 1 2024, 5:43 AM
Unknown Object (File)
Sep 29 2024, 11:56 PM
View All Files
Subscribers
brueffer
emaste
imp
netchild

Details

Reviewers
tijl
emaste
brueffer
netchild
Group Reviewers
manpages
Linux Emulation
Commits
rS354691: Improve Linuxulator man pages to better reflect the current state,
Summary

Improve Linuxulator man pages to better reflect the current state.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27392
Build 25639: arc lint + arc unit

Event Timeline

trasz created this revision.Nov 7 2019, 6:18 PM
Herald added a reviewer: manpages. · View Herald TranscriptNov 7 2019, 6:18 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B27392: Diff 64049.Nov 7 2019, 6:18 PM
trasz added a reviewer: Linux Emulation.Nov 7 2019, 6:18 PM
emaste added a subscriber: emaste.Nov 7 2019, 7:08 PM
emaste added inline comments.
share/man/man4/linux.4
55–57

It probably is worth leaving in some statment about this not being 100%

trasz updated this revision to Diff 64068.Nov 8 2019, 11:14 AM

Add BUGS.

Harbormaster completed remote builds in B27397: Diff 64068.Nov 8 2019, 11:14 AM
trasz marked an inline comment as done.Nov 8 2019, 11:14 AM

That's true; I've added a BUGS section.

trasz added reviewers: tijl, emaste.Nov 11 2019, 11:38 AM
tijl added inline comments.Nov 11 2019, 1:28 PM
share/man/man4/linux.4
78

s/compat/emulators/

trasz updated this revision to Diff 64178.Nov 11 2019, 3:07 PM

Apply feedback from emaste@ and tijl@.

Harbormaster completed remote builds in B27447: Diff 64178.Nov 11 2019, 3:07 PM
trasz marked an inline comment as done.Nov 11 2019, 3:07 PM
brueffer added a subscriber: brueffer.Nov 11 2019, 3:21 PM
brueffer added inline comments.
share/man/man4/linux.4
78

We mark up ports paths with .Pa if I recall correctly.

84

Unneeded .Pp, this macro has no effect before/after .Sh

trasz updated this revision to Diff 64183.Nov 11 2019, 4:05 PM

Feedback from brueffer@.

Harbormaster completed remote builds in B27449: Diff 64183.Nov 11 2019, 4:05 PM
trasz marked 2 inline comments as done.Nov 11 2019, 4:05 PM

Fixed, thanks!

brueffer accepted this revision.Nov 11 2019, 4:51 PM
This revision is now accepted and ready to land.Nov 11 2019, 4:51 PM
emaste accepted this revision.Nov 11 2019, 9:38 PM

LGTM

netchild requested changes to this revision.Nov 12 2019, 10:32 AM
netchild mentioned this in D22320: Add linux_skip_mounts.
netchild added a subscriber: netchild.

Please add something about linux_skip_mounts from https://reviews.freebsd.org/D22320

This revision now requires changes to proceed.Nov 12 2019, 10:33 AM
trasz updated this revision to Diff 64229.Nov 12 2019, 3:06 PM

Document linux_mounts_enable.

Harbormaster completed remote builds in B27471: Diff 64229.Nov 12 2019, 3:06 PM
tijl added inline comments.Nov 13 2019, 10:05 AM
share/man/man4/linux.4
83–86

The linux_base ports run some Linux programs on installation, e.g. Linux ldconfig to create /compat/linux/etc/ld.so.cache. So I would change the order here. First add linux_enable to /etc/rc.conf, then enable Linux compatibility using 'service linux start', and then install linux_base-c7. That also means that /etc/rc.d/linux should create /compat/linux and /compat/linux/{dev,proc,sys} before mounting file systems because these directories might not exist.

trasz added inline comments.Nov 13 2019, 1:06 PM
share/man/man4/linux.4
83–86

Good point, but can... we move it to another review? What you're suggesting also touches the rc script itself, and there might be different ways it could be solved.

tijl added inline comments.Nov 13 2019, 2:35 PM
share/man/man4/linux.4
83–86

Sure.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 13 2019, 8:32 PM
Closed by commit rS354691: Improve Linuxulator man pages to better reflect the current state, (authored by trasz). · Explain Why
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS354691: Improve Linuxulator man pages to better reflect the current state,.
trasz added inline comments.Nov 13 2019, 8:32 PM
share/man/man4/linux.4
83–86

Perhaps here: https://reviews.freebsd.org/Z15

Revision Contents
Changeset List

PathSize
share/
man/
man4/
96 lines
man5/
1 line
3 lines

Diff 64049

View Options

share/man/man4/linux.4

Loading...
View Options

share/man/man5/linprocfs.5

Loading...
View Options

share/man/man5/linsysfs.5

Loading...