Page MenuHomeFreeBSD

Fix pmap_page_is_mapped() for arm64 and riscv.
ClosedPublic

Authored by markj on Sep 27 2019, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 18, 9:00 AM
Unknown Object (File)
Tue, Apr 14, 9:12 PM
Unknown Object (File)
Tue, Apr 14, 1:29 PM
Unknown Object (File)
Tue, Apr 14, 8:28 AM
Unknown Object (File)
Sat, Apr 11, 11:30 PM
Unknown Object (File)
Wed, Apr 1, 3:09 PM
Unknown Object (File)
Sun, Mar 29, 10:44 PM
Unknown Object (File)
Thu, Mar 26, 8:10 PM
Subscribers

Details

Summary

To be correct, this function needs to look at 2MB mappings as well. I
just copied the implementation from amd64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc added inline comments.
sys/arm64/include/pmap.h
170–171 ↗(On Diff #62653)

You need to replace this by the function declaration from amd64:

boolean_t pmap_page_is_mapped(vm_page_t m);

This revision is now accepted and ready to land.Sep 27 2019, 4:57 PM
This revision now requires review to proceed.Sep 27 2019, 5:24 PM

Here is a take-it-or-leave comment: Consider conversion from "boolean_t" to "bool".

This revision is now accepted and ready to land.Sep 27 2019, 9:24 PM