Page MenuHomeFreeBSD

Update SIFTR man page, and minor trailing whitespace nit.
ClosedPublic

Authored by rscheff_gmx.at on Sep 12 2019, 3:17 PM.

Details

Summary

D18897 added a simple port filter as sysctl tunable to siftr.

The new sysctl was not added to the siftr.4 man page at the time.

This updates the man page, and removes one left over trailing whitespace.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rscheff_gmx.at created this revision.Sep 12 2019, 3:17 PM
bcr added a comment.Sep 12 2019, 3:41 PM

Two fixes for the man page.

share/man/man4/siftr.4
138 ↗(On Diff #61979)

s/elegible/eligible/

139 ↗(On Diff #61979)

s/only/other/

or

s/only//

or even

s/any//

?

  • man page typos
rscheff_gmx.at marked 2 inline comments as done.Sep 12 2019, 3:47 PM
bcr accepted this revision.Sep 12 2019, 3:48 PM

OK, thanks for the quick fixes.
The .Dd needs to be bumped when the change is committed, but I leave that to others.

This revision is now accepted and ready to land.Sep 12 2019, 3:48 PM
  • bumping .Dd date
This revision now requires review to proceed.Sep 12 2019, 4:09 PM
  • update siftr man page timestamp and fix trailing whitespace
rscheff_gmx.at retitled this revision from Update SIFTR man page, and make siftr port_filter work as intended to Update SIFTR man page, and minor trailing whitespace nit..Mon, Oct 7, 9:22 AM
rscheff_gmx.at edited the summary of this revision. (Show Details)

Removed the filter logic changes as they were logically equivalent with the already implemented logic - could not figure out why I though this may not work properly (possibly not clearing the siftr logs properly when checking).

This Diff is therefore only the man page update, complete with bcr's comments to improve the original wording, and is ready to land.

bcr accepted this revision.Mon, Oct 7, 9:30 AM

OK, thanks for the man page fixes. It can be committed with the source change now.

This revision is now accepted and ready to land.Mon, Oct 7, 9:30 AM