Details

Reviewers

cc
brooks
bcr

Group Reviewers

manpages

Commits

rS353412: MFS r353402:
rS353402: MFC r353290:
rS353290: In r343587 a simple port filter as sysctl tunable was added to siftr.

Summary

D18897 added a simple port filter as sysctl tunable to siftr.

The new sysctl was not added to the siftr.4 man page at the time.

This updates the man page, and removes one left over trailing whitespace.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Sep 12 2019, 3:17 PM

Harbormaster completed remote builds in B26426: Diff 61979.Sep 12 2019, 3:17 PM

rscheff added a reviewer: bcr.Sep 12 2019, 3:20 PM

Two fixes for the man page.

share/man/man4/siftr.4
138 ↗	(On Diff #61979)	s/elegible/eligible/
139 ↗	(On Diff #61979)	s/only/other/ or s/only// or even s/any// ?

man page typos

Harbormaster completed remote builds in B26428: Diff 61983.Sep 12 2019, 3:46 PM

rscheff marked 2 inline comments as done.Sep 12 2019, 3:47 PM

OK, thanks for the quick fixes.
The .Dd needs to be bumped when the change is committed, but I leave that to others.

This revision is now accepted and ready to land.Sep 12 2019, 3:48 PM

bumping .Dd date

This revision now requires review to proceed.Sep 12 2019, 4:09 PM

Harbormaster completed remote builds in B26431: Diff 61986.Sep 12 2019, 4:09 PM

update siftr man page timestamp and fix trailing whitespace

Harbormaster completed remote builds in B26907: Diff 62982.Oct 7 2019, 9:18 AM

rscheff retitled this revision from Update SIFTR man page, and make siftr port_filter work as intended to Update SIFTR man page, and minor trailing whitespace nit..Oct 7 2019, 9:22 AM

rscheff edited the summary of this revision. (Show Details)

Removed the filter logic changes as they were logically equivalent with the already implemented logic - could not figure out why I though this may not work properly (possibly not clearing the siftr logs properly when checking).

This Diff is therefore only the man page update, complete with bcr's comments to improve the original wording, and is ready to land.

OK, thanks for the man page fixes. It can be committed with the source change now.

This revision is now accepted and ready to land.Oct 7 2019, 9:30 AM

Closed by commit rS353290: In r343587 a simple port filter as sysctl tunable was added to siftr. (authored by tuexen). · Explain WhyOct 7 2019, 8:35 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS353290: In r343587 a simple port filter as sysctl tunable was added to siftr..

Herald added a reviewer: manpages. · View Herald TranscriptOct 7 2019, 8:35 PM

Herald added a subscriber: imp. · View Herald Transcript

tuexen added a commit: rS353402: MFC r353290:.Oct 10 2019, 2:54 PM

tuexen added a commit: rS353412: MFS r353402:.Oct 10 2019, 6:39 PM