Page MenuHomeFreeBSD

Rework r339635 to fix .depend.tables.h handling.
ClosedPublic

Authored by bdrewery on Aug 16 2019, 8:00 PM.

Details

Summary

Avoid touching the tables.h file unless it has changed to avoid unneeded
rebuilds.

MFC after: 2 weeks
PR: 238828
Sponsored by: DellEMC

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bdrewery created this revision.Aug 16 2019, 8:00 PM
emaste added inline comments.Aug 16 2019, 8:15 PM
lib/libsysdecode/Makefile
127–128 ↗(On Diff #60909)

need to remove these explicit dependencies

emaste added inline comments.Aug 16 2019, 8:18 PM
lib/libsysdecode/Makefile
127–128 ↗(On Diff #60909)

and then incdir can go away also, expanded inline below.

emaste added inline comments.Aug 16 2019, 8:19 PM
lib/libsysdecode/mktables
177 ↗(On Diff #60909)

> probably?

LGTM other than the minor comments inline

bdrewery updated this revision to Diff 60916.Aug 16 2019, 9:32 PM
bdrewery marked 3 inline comments as done.

Review findings

This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2019, 10:34 PM
This revision was automatically updated to reflect the committed changes.