Page MenuHomeFreeBSD

First pass at a LINT for arm64.
ClosedPublic

Authored by imp on Wed, Aug 7, 11:40 PM.

Details

Summary

Create a rough and ready NOTES file from GENERIC, remove the duplication from
sys/conf/NOTES and add relevant no* directives to make this compile.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp created this revision.Wed, Aug 7, 11:40 PM
imp updated this revision to Diff 60560.Thu, Aug 8, 12:04 AM

Remove duplicate options -- make it suck a little less

imp updated this revision to Diff 60561.Thu, Aug 8, 12:06 AM

final tweaks.

jhb added a subscriber: jhb.Thu, Aug 8, 12:10 AM
jhb added inline comments.
sys/arm64/conf/NOTES
28 ↗(On Diff #60561)

Shouldn't this be in sys/conf/NOTES?

imp added inline comments.Thu, Aug 8, 2:40 PM
sys/arm64/conf/NOTES
28 ↗(On Diff #60561)

Hmmm. Good point.'

jhb accepted this revision.Thu, Aug 8, 4:41 PM
This revision is now accepted and ready to land.Thu, Aug 8, 4:41 PM
manu accepted this revision.Thu, Aug 8, 4:48 PM
andrew added inline comments.Thu, Aug 8, 4:49 PM
sys/arm64/conf/NOTES
213–214 ↗(On Diff #60561)

Should this be moved to the i386 & amd64 NOTES file if it's x86 specific?

jhb added inline comments.Thu, Aug 8, 4:57 PM
sys/arm64/conf/NOTES
213–214 ↗(On Diff #60561)

I suspect we can do that, though the way we will do it is to add a sys/x86/conf/NOTES and there are actually several things here that can then move. ppc's LINT also has several nodevice/nooptions and an x86 NOTES will help us remove several of those as well.

imp updated this revision to Diff 60595.Thu, Aug 8, 5:52 PM

Fix after fixing compat_freebsd32 + compat_43 fixes

This revision now requires review to proceed.Thu, Aug 8, 5:52 PM
imp added inline comments.Thu, Aug 8, 5:53 PM
sys/arm64/conf/NOTES
213–214 ↗(On Diff #60561)

Yes, it can, but let's get this into the tree first.

This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rS350766: First pass at a LINT for arm64. (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp marked 3 inline comments as done.Thu, Aug 8, 5:57 PM