Differential D21184

First pass at a LINT for arm64.
ClosedPublic
Actions

Authored by imp on Aug 7 2019, 11:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sep 29 2024, 1:29 PM

	Unknown Object (File)
	Sep 20 2024, 10:45 PM

	Unknown Object (File)
	Sep 20 2024, 10:45 PM

	Unknown Object (File)
	Sep 20 2024, 10:45 PM

	Unknown Object (File)
	Sep 20 2024, 10:44 PM

	Unknown Object (File)
	Sep 20 2024, 10:44 PM

	Unknown Object (File)
	Sep 20 2024, 10:44 PM

	Unknown Object (File)
	Sep 20 2024, 10:32 PM

View All 64 Files

Subscribers

Details

Reviewers

manu
• ian
andrew
jhb

Commits

rS350766: First pass at a LINT for arm64.

Summary

Create a rough and ready NOTES file from GENERIC, remove the duplication from
sys/conf/NOTES and add relevant no* directives to make this compile.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Aug 7 2019, 11:40 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 7 2019, 11:40 PM

Herald added subscribers: jonathan, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B25736: Diff 60559.Aug 7 2019, 11:40 PM

imp added reviewers: • ian, andrew.Aug 7 2019, 11:46 PM

Remove duplicate options -- make it suck a little less

Harbormaster completed remote builds in B25737: Diff 60560.Aug 8 2019, 12:04 AM

final tweaks.

Harbormaster completed remote builds in B25738: Diff 60561.Aug 8 2019, 12:06 AM

jhb added a subscriber: jhb.Aug 8 2019, 12:10 AM

jhb added inline comments.

sys/arm64/conf/NOTES
28 ↗	(On Diff #60561)	Shouldn't this be in sys/conf/NOTES?

imp added inline comments.Aug 8 2019, 2:40 PM

sys/arm64/conf/NOTES
28 ↗	(On Diff #60561)	Hmmm. Good point.'

jhb accepted this revision.Aug 8 2019, 4:41 PM

This revision is now accepted and ready to land.Aug 8 2019, 4:41 PM

manu accepted this revision.Aug 8 2019, 4:48 PM

andrew added inline comments.Aug 8 2019, 4:49 PM

sys/arm64/conf/NOTES
213–214 ↗	(On Diff #60561)	Should this be moved to the i386 & amd64 NOTES file if it's x86 specific?

jhb added inline comments.Aug 8 2019, 4:57 PM

sys/arm64/conf/NOTES
213–214 ↗	(On Diff #60561)	I suspect we can do that, though the way we will do it is to add a sys/x86/conf/NOTES and there are actually several things here that can then move. ppc's LINT also has several nodevice/nooptions and an x86 NOTES will help us remove several of those as well.

Fix after fixing compat_freebsd32 + compat_43 fixes

This revision now requires review to proceed.Aug 8 2019, 5:52 PM

Harbormaster completed remote builds in B25754: Diff 60595.Aug 8 2019, 5:52 PM

imp added inline comments.Aug 8 2019, 5:53 PM

sys/arm64/conf/NOTES
213–214 ↗	(On Diff #60561)	Yes, it can, but let's get this into the tree first.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2019, 5:55 PM

Closed by commit rS350766: First pass at a LINT for arm64. (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS350766: First pass at a LINT for arm64..

imp marked 3 inline comments as done.Aug 8 2019, 5:57 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

conf/

5 lines

245 lines

Diff 60596

head/sys/arm64/conf/Makefile

Loading...

head/sys/arm64/conf/NOTES

Loading...