Page MenuHomeFreeBSD

Enable NVME option (nvmecontrol, etc) on aarch64
ClosedPublic

Authored by val_packett.cool on Aug 6 2019, 1:30 PM.
Tags
Referenced Files
F103221715: D21168.id.diff
Fri, Nov 22, 9:15 AM
Unknown Object (File)
Sun, Nov 17, 7:06 AM
Unknown Object (File)
Sat, Oct 26, 5:45 AM
Unknown Object (File)
Oct 5 2024, 2:04 PM
Unknown Object (File)
Sep 21 2024, 2:27 PM
Unknown Object (File)
Sep 19 2024, 1:21 PM
Unknown Object (File)
Sep 7 2024, 1:40 PM
Unknown Object (File)
Sep 1 2024, 6:43 AM

Details

Summary

NVMe itself works fine on aarch64, let's install nvmecontrol and whatever else the option enables.

Test Plan

nvmecontrol builds and runs. I don't currently have an adapter from M.2 to full PCIe (nor an SSD that's already in PCIe form factor) though. I guess it's possible to test with the virtual NVMe drive in AWS EC2 haha.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Have you run this and does it work?
Assuming yes, this is a good change.

This revision is now accepted and ready to land.Aug 6 2019, 5:51 PM
In D21168#460060, @imp wrote:

Have you run this and does it work?

As I mentioned

nvmecontrol builds and runs

but I don't have an aarch64 system with a real NVMe drive to do anything interesting with it.

In D21168#460117, @greg_unrelenting.technology wrote:
In D21168#460060, @imp wrote:

Have you run this and does it work?

As I mentioned

nvmecontrol builds and runs

but I don't have an aarch64 system with a real NVMe drive to do anything interesting with it.

OK. Does the kernel at least build? If so, I'll push this in if we've not punished you with a commit bit yet :)

In D21168#460154, @imp wrote:
In D21168#460117, @greg_unrelenting.technology wrote:
In D21168#460060, @imp wrote:

Have you run this and does it work?

As I mentioned

nvmecontrol builds and runs

but I don't have an aarch64 system with a real NVMe drive to do anything interesting with it.

OK. Does the kernel at least build? If so, I'll push this in if we've not punished you with a commit bit yet :)

actually, scratch that. I'll push this in if it passes a buildworld I've just started.

This revision was automatically updated to reflect the committed changes.